-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to compile protostuff using jdk 11 #374
Conversation
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read opensearch-project#320). This PR rebuilt protostuff using JDK 11. Testing done: 1. Tested both single-stream and HCAD real-time detectors. Signed-off-by: Kaituo Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making the change!
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
============================================
- Coverage 79.11% 78.99% -0.13%
+ Complexity 4094 4079 -15
============================================
Files 295 295
Lines 17207 17207
Branches 1826 1826
============================================
- Hits 13614 13593 -21
- Misses 2695 2719 +24
+ Partials 898 895 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-374-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a79028f8ee2098fa94e5e4b8ba81affce24b2b8c
# Push it to GitHub
git push --set-upstream origin backport/backport-374-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
@VachaShah any idea why the backport is failing? ^ |
Looks like there is some conflict:
|
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read #320). This PR rebuilt protostuff using JDK 11. Testing done: 1. Tested both single-stream and HCAD real-time detectors. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit a79028f)
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read #320). This PR rebuilt protostuff using JDK 11. Testing done: 1. Tested both single-stream and HCAD real-time detectors. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit a79028f)
Description
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read #320). This PR rebuilt protostuff using JDK 11.
Testing done:
Issues Resolved
opensearch-project/opensearch-build#1613
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.