Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK 8 to CI #409

Closed
wants to merge 1 commit into from
Closed

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Mar 9, 2022

Signed-off-by: Tyler Ohlsen [email protected]

Description

Adds JDK8 to CI.

Issues Resolved

Resolves #320

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler requested a review from a team March 9, 2022 23:00
@ohltyler
Copy link
Member Author

ohltyler commented Mar 9, 2022

@dblock there has been a manual build of protostuff jars by @kaituo built with JDK11 (#374), which causes failures when running against JDK8. Note it was originally built with JDK14 (#373) but caused infra distribution build failures, since those run on JDK11. So I think the path with the least amount of friction is to not run CI against JDK8.

Workflow failure:

bad class file: /home/runner/work/anomaly-detection/anomaly-detection/lib/protostuff-api-1.8.0-SNAPSHOT.jar(io/protostuff/LinkedBuffer.class)
    class file has wrong version 55.0, should be 52.0

@ohltyler ohltyler marked this pull request as draft March 9, 2022 23:22
@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Mar 10, 2022

Manual built protostuff is to fix this #263, @dblock, do you think it's ok to not fix that warning? It will be best if we can push protostuff team to publish a new version fixing that issue.

@dblock
Copy link
Member

dblock commented Mar 10, 2022

Fixing in #418.

@dblock dblock closed this Mar 10, 2022
@ohltyler ohltyler deleted the add-jdk-8 branch March 10, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default CI Java Version to Java 11, run tests on 8, 14 and 17
3 participants