Add JDK 11 to CI test matrix #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
changed the title
Signed-off-by: Tyler Ohlsen <[email protected]>
amitgalitz
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
LGTM, just make sure to wait until CI passes especially as this involves CI workflow changes. Also JDK8 might not be working because of protostuff dependency compiled with java 11, before that change was pushed it in, it was okay to use runtime jdk8. However the exception itself mentions something was compiled with java version 54 which is equivalent to java 10 so not 100% sure. Can be addressed in future PRs
ylwu-amzn
reviewed
Mar 2, 2022
| Build-ad: | ||
| strategy: | ||
| matrix: | ||
| java: [14] | ||
| java: [11, 14] |
There was a problem hiding this comment.
All plugins and OpenSearch core should make sure Java 11 works for 1.3 release?
There was a problem hiding this comment.
11 is the default used by bundle build / integ tests
ylwu-amzn
approved these changes
Mar 2, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2bf3b0d)
ohltyler
added a commit
that referenced
this pull request
Mar 2, 2022
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2bf3b0d)
ohltyler
added
the
infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Ohlsen [email protected]
Description
One of the campaigns for upcoming 1.3 release is testing on JDK 11, with optional versions of 8, 14, 17. This updates the workflow to add JDK 11. There are other problems with 8/17 so ignoring those for now.
Also removes CD workflow since that hasn't been used since pre-OpenSearch days.
Issues Resolved
Resolves #320
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.