Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and configure Log4j JUL adapter for Lucene 9.4 #4754

Merged

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 12, 2022

Adds log4j-jul dependency (along with license and notice files) and configures the java.util.logging log4j adapater to route all JUL logs to the proper opensearch locations setup through the LogConfigurator for Lucene 9.4 compatibility.

closes #4753
relates #4637

Adds log4j-jul dependency (along with license and notice files) and
configures the java.util.logging log4j adapater to route all JUL logs
to the proper opensearch locations setup through the LogConfigurator for
Lucene 9.4 compatibility.

Signed-off-by: Nicholas Knize <[email protected]>
@nknize nknize added enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch labels Oct 12, 2022
@nknize nknize requested review from a team and reta as code owners October 12, 2022 18:02
Signed-off-by: Nicholas Knize <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4754 (671f140) into main (10f8ed8) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 671f140 differs from pull request most recent head 6e55035. Consider uploading reports for the commit 6e55035 to get more accurate results

@@             Coverage Diff              @@
##               main    #4754      +/-   ##
============================================
- Coverage     70.78%   70.78%   -0.01%     
+ Complexity    57692    57648      -44     
============================================
  Files          4660     4660              
  Lines        276601   276602       +1     
  Branches      40307    40307              
============================================
- Hits         195801   195796       -5     
+ Misses        64572    64532      -40     
- Partials      16228    16274      +46     
Impacted Files Coverage Δ
...org/opensearch/common/logging/LogConfigurator.java 24.28% <0.00%> (-0.36%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-52.95%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-45.00%) ⬇️
...pensearch/indices/breaker/CircuitBreakerStats.java 27.77% <0.00%> (-41.67%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
...search/search/aggregations/pipeline/EwmaModel.java 24.44% <0.00%> (-28.89%) ⬇️
...rch/client/transport/NoNodeAvailableException.java 42.85% <0.00%> (-28.58%) ⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java 51.72% <0.00%> (-27.59%) ⬇️
... and 485 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@@ -0,0 +1,202 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nknize for this change. I have one question around reviewing the licensing files. As a reviewer, how do I ensure that terms and conditions are acceptable ?

Opened an issue sometime back to define the guidelines: #3815

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we have an automated process you'll have to cross-reference the maven repo: https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-jul/2.19.0

@nknize nknize merged commit beb9915 into opensearch-project:main Oct 12, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4754-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 beb99150a84d54bb26182d50e363beea79d1a09a
# Push it to GitHub
git push --set-upstream origin backport/backport-4754-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4754-to-2.x.

nknize added a commit to nknize/OpenSearch that referenced this pull request Oct 12, 2022
…oject#4754)

Adds log4j-jul dependency (along with license and notice files) and
configures the java.util.logging log4j adapater to route all JUL logs
to the proper opensearch locations setup through the LogConfigurator for
Lucene 9.4 compatibility.

Signed-off-by: Nicholas Knize <[email protected]>
(cherry picked from commit beb9915)
nknize added a commit to nknize/OpenSearch that referenced this pull request Oct 12, 2022
…oject#4754)

Adds log4j-jul dependency (along with license and notice files) and
configures the java.util.logging log4j adapater to route all JUL logs
to the proper opensearch locations setup through the LogConfigurator for
Lucene 9.4 compatibility.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit beb9915)
@uschindler
Copy link
Contributor

Looks correct. Thanks.

nknize added a commit to nknize/OpenSearch that referenced this pull request Oct 18, 2022
…oject#4754)

Adds log4j-jul dependency (along with license and notice files) and
configures the java.util.logging log4j adapater to route all JUL logs
to the proper opensearch locations setup through the LogConfigurator for
Lucene 9.4 compatibility.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit beb9915)
reta pushed a commit that referenced this pull request Oct 18, 2022
Adds log4j-jul dependency (along with license and notice files) and
configures the java.util.logging log4j adapater to route all JUL logs
to the proper opensearch locations setup through the LogConfigurator for
Lucene 9.4 compatibility.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit beb9915)
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
…oject#4754)

Adds log4j-jul dependency (along with license and notice files) and
configures the java.util.logging log4j adapater to route all JUL logs
to the proper opensearch locations setup through the LogConfigurator for
Lucene 9.4 compatibility.

Signed-off-by: Nicholas Knize <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install and configure Log4j JUL adapter for Lucene 9.4
5 participants