Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review guidelines for licensing files #3815

Open
dreamer-89 opened this issue Jul 7, 2022 · 1 comment
Open

Review guidelines for licensing files #3815

dreamer-89 opened this issue Jul 7, 2022 · 1 comment
Labels
discuss Issues intended to help drive brainstorming and decision making documentation Improvements or additions to documentation enhancement Enhancement or improvement to existing feature or request

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Jul 7, 2022 •
edited
Loading

Coming from #3774, there are no specific guidelines around reviewing licensing terms and conditions. Today, LicenseAnalyzer (runs as part of precommit task) is used to identify violating licensing terms. But, not sure if this is sufficient for all cases and reviewers can rely on it.

Created this issue to get the community feedback and have documentation around reviewing these files.
@dreamer-89 dreamer-89 added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 7, 2022
@mch2 mch2 added documentation Improvements or additions to documentation discuss Issues intended to help drive brainstorming and decision making and removed untriaged labels Jul 11, 2022
@dreamer-89 dreamer-89 mentioned this issue Oct 12, 2022
Merged
@dreamer-89
Copy link
Member Author

dreamer-89 commented Oct 12, 2022 •
edited
Loading

We can match the terms and conditions from dependency source (e.g. maven), thanks to @nknize for suggesting this here.

@github-project-automation github-project-automation bot moved this to Planned work items in Test roadmap format Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Issues intended to help drive brainstorming and decision making documentation Improvements or additions to documentation enhancement Enhancement or improvement to existing feature or request
Projects
Test roadmap format
Status: Planned work items
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mch2 @dreamer-89