Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Install and configure Log4j JUL adapter for Lucene 9.4 (#4754) #4758

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 12, 2022

Backport beb9915 from #4754

@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 12, 2022
@nknize nknize requested review from a team and reta as code owners October 12, 2022 21:25
@nknize nknize force-pushed the backport/backport-4754-to-2.x branch from 65c366a to a76cfb8 Compare October 12, 2022 21:26
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…oject#4754)

Adds log4j-jul dependency (along with license and notice files) and
configures the java.util.logging log4j adapater to route all JUL logs
to the proper opensearch locations setup through the LogConfigurator for
Lucene 9.4 compatibility.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit beb9915)
@nknize nknize force-pushed the backport/backport-4754-to-2.x branch from a76cfb8 to 9bd85dd Compare October 18, 2022 19:35
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Oct 18, 2022

#4831

This test keeps randomly failing.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4758 (9bd85dd) into 2.x (a90fd73) will increase coverage by 0.06%.
The diff coverage is 62.39%.

@@             Coverage Diff              @@
##                2.x    #4758      +/-   ##
============================================
+ Coverage     70.62%   70.69%   +0.06%     
- Complexity    57126    57506     +380     
============================================
  Files          4585     4617      +32     
  Lines        274526   276033    +1507     
  Branches      40233    40387     +154     
============================================
+ Hits         193876   195130    +1254     
- Misses        64403    64661     +258     
+ Partials      16247    16242       -5     
Impacted Files Coverage Δ
...main/java/org/opensearch/gradle/PublishPlugin.java 43.43% <0.00%> (-0.45%) ⬇️
...ava/org/opensearch/client/RestHighLevelClient.java 41.75% <0.00%> (-2.27%) ⬇️
...apshots/restore/RestoreSnapshotRequestBuilder.java 15.78% <0.00%> (-0.88%) ⬇️
...er/src/main/java/org/opensearch/client/Client.java 40.00% <ø> (ø)
.../org/opensearch/client/support/AbstractClient.java 34.25% <0.00%> (-0.45%) ⬇️
...org/opensearch/common/logging/LogConfigurator.java 18.08% <0.00%> (-0.20%) ⬇️
...main/java/org/opensearch/common/lucene/Lucene.java 67.30% <ø> (+1.48%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
.../java/org/opensearch/common/util/FeatureFlags.java 50.00% <ø> (ø)
...ateway/TransportNodesListGatewayStartedShards.java 51.00% <0.00%> (+13.42%) ⬆️
... and 578 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit e53e6ad into opensearch-project:2.x Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants