Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Revert "Add cluster setting cluster.restrict.index.replication_type t… #11073

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[2.x] Revert "Add cluster setting cluster.restrict.index.replication_type t… #11073

merged 1 commit into from
Nov 7, 2023

Conversation

Poojita-Raj
Copy link
Contributor

@Poojita-Raj Poojita-Raj commented Nov 2, 2023 •
edited by peternied
Loading

…… (#10866) (#10876)" in 2.x

This reverts commit 83b0371 in 2.x.

Description

Reverts the setting until we find a better solution for restricting the change of index replication type in certain scenarios.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied
Copy link
Member

@Poojita-Raj Could you update the description and include this change is being reverted?

@peternied peternied mentioned this pull request Nov 2, 2023
Merged
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Compatibility status:

Checks if related components are compatible with change 562c08a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions github-actions bot added the bug Something isn't working label Nov 2, 2023
@Poojita-Raj Poojita-Raj changed the title Revert "Add cluster setting cluster.restrict.index.replication_type t… [2.x] Revert "Add cluster setting cluster.restrict.index.replication_type t… Nov 2, 2023
@peternied peternied self-assigned this Nov 2, 2023
@Poojita-Raj
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/29493/

* **CommitID:** [562c08a](https://github.com/opensearch-project/OpenSearch/commit/562c08aed98d92239f0ff93f9d529da31229c2b4)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#10154
#10006
#10798

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/29564/

* **CommitID:** [562c08a](https://github.com/opensearch-project/OpenSearch/commit/562c08aed98d92239f0ff93f9d529da31229c2b4)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#8771

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@dreamer-89 dreamer-89 merged commit 342cc17 into opensearch-project:2.x Nov 7, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees

@peternied peternied

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Poojita-Raj @peternied @kotwanikunal @dreamer-89