Revert "Add cluster setting cluster.restrict.index.replication_type t…

[Poojita-Raj]

…… (#10866)"

This reverts commit 8b21739.

Description

Reverts the setting until we find a better solution for restricting the change of index replication type in certain scenarios.

• Original issue: Add cluster setting cluster.restrict.index.replication_type t… #10866

Related Issues

• Resolves [BUG] Need to revert cluster.restrict.index.replication-type setting #11078

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peternied]

@Poojita-Raj Could you update the description and include this change is being reverted? (Seems like I'm seeing double with #11073)

[github-actions]

Compatibility status:

Checks if related components are compatible with change ae58096

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/29491/
• CommitID: a2e735a

[codecov]

Codecov Report

Merging #11072 (ae58096) into main (63aff16) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main   #11072      +/-   ##
============================================
- Coverage     71.29%   71.24%   -0.05%     
  Complexity    58742    58742              
============================================
  Files          4872     4872              
  Lines        276777   276773       -4     
  Branches      40240    40240              
============================================
- Hits         197316   197192     -124     
- Misses        62943    63090     +147     
+ Partials      16518    16491      -27     

Files	Coverage Δ
...h/cluster/metadata/MetadataCreateIndexService.java	79.75% <ø> (-0.21%)	⬇️
...rg/opensearch/common/settings/ClusterSettings.java	92.85% <ø> (ø)
...in/java/org/opensearch/indices/IndicesService.java	68.10% <ø> (-2.92%)	⬇️
...s/replication/SegmentReplicationTargetService.java	56.17% <100.00%> (+0.56%)	⬆️

... and 471 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testIndexReopenClose

• URL: https://build.ci.opensearch.org/job/gradle-check/29492/
• CommitID: ae58096
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[Poojita-Raj]

@peternied Thanks for the pointer! Included the link to the original issue. Renamed the second revert to make it clear it's for 2.x.