-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster setting cluster.restrict.index.replication_type t… #10866
Add cluster setting cluster.restrict.index.replication_type t… #10866
Conversation
…o restrict setting of index setting replication type Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Poojita Raj <[email protected]>
Compatibility status:Checks if related components are compatible with change ae5a785 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10866 +/- ##
=========================================
Coverage 71.25% 71.25%
+ Complexity 58684 58672 -12
=========================================
Files 4869 4869
Lines 276512 276496 -16
Branches 40204 40203 -1
=========================================
- Hits 197030 197026 -4
- Misses 63020 63031 +11
+ Partials 16462 16439 -23
|
...lClusterTest/java/org/opensearch/indices/replication/SegmentReplicationClusterSettingIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Poojita Raj <[email protected]>
Thanks for the review @mch2! Addressed all the changes, please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10866-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8b2173910f754a48773b3283e1a511cbc1a9db78
# Push it to GitHub
git push --set-upstream origin backport/backport-10866-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…earch-project#10866) * Add cluster setting CLUSTER_RESTRICT_INDEX_REPLICATION_TYPE_SETTING to restrict setting of index setting replication type Signed-off-by: Poojita Raj <[email protected]> * Add Changelog entry Signed-off-by: Poojita Raj <[email protected]> * refactoring Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]>
… (#10876) * Add cluster setting CLUSTER_RESTRICT_INDEX_REPLICATION_TYPE_SETTING to restrict setting of index setting replication type * Add Changelog entry * refactoring --------- Signed-off-by: Poojita Raj <[email protected]>
opensearch-project#10866)" This reverts commit 8b21739. Signed-off-by: Poojita Raj <[email protected]>
opensearch-project#10866) (opensearch-project#10876)" This reverts commit 83b0371. Signed-off-by: Poojita Raj <[email protected]>
#10866)" (#11072) This reverts commit 8b21739. Signed-off-by: Poojita Raj <[email protected]>
#10866) (#10876)" (#11073) This reverts commit 83b0371. Signed-off-by: Poojita Raj <[email protected]>
opensearch-project#10866)" (opensearch-project#11072) This reverts commit 8b21739. Signed-off-by: Poojita Raj <[email protected]>
…earch-project#10866) * Add cluster setting CLUSTER_RESTRICT_INDEX_REPLICATION_TYPE_SETTING to restrict setting of index setting replication type Signed-off-by: Poojita Raj <[email protected]> * Add Changelog entry Signed-off-by: Poojita Raj <[email protected]> * refactoring Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
opensearch-project#10866)" (opensearch-project#11072) This reverts commit 8b21739. Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…o restrict setting of index setting replication type
Description
Introduces a cluster level setting CLUSTER_RESTRICT_INDEX_REPLICATION_TYPE_SETTING = cluster.restrict.index.replication_type that can restrict setting of index.replication.type setting in a cluster.
Default value = false.
Throws an exception when we try to set the index replication type when the cluster restrict setting is enabled.
Related Issues
Resolves #10868
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.