-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Emiproc: A Python package for emission inventory processing #7337
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🔴 License found: |
Five most similar historical JOSS papers: HydroMT: Automated and reproducible model building and analysis PyHeatDemand - Processing Tool for Heat Demand Data Pyinterpolate: Spatial interpolation in Python for point measurements and aggregated datasets EmissV: an R package to create vehicular and other emissions for air quality models GridFormat: header-only C++-library for grid file I/O |
@lionel42 – thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy. For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!
Just noting that this seems to be an error on our part – my checking of the repository shows a BSD license so I think there's nothing to do here. |
This is not correct. We have changed the licence to a BSD-3 licence for the new package update |
Hi @lionel42 and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:
In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. |
|
@kthyng Thanks for the feedback
Yes, I just setup the github action to release to pypi: https://pypi.org/project/emiproc/#description
I have reduced the size of some sections. Is there a possibility to trigger the bot again to count the words now ?
I am not sure I understand this point, the references look okay for me. |
For reviewers I would suggest:
|
Great! I see it there. Please update your installation instructions too. |
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
An an example, line 27 has the reference in parentheses but it shouldn't be. As per the new comments, the paper length is now 1133. If you can shorten a little more that would be great, but if not, it is close enough. |
Here it is: installation with pip: |
I removed the parenthesis around citations where I understood they were not required. Also I removed a bit more words. We are still above 1000 but I don't see where I could reduce more. I guess we can decide later based on the reviewer's comments. |
@editorialbot generate pdf |
Five most similar historical JOSS papers: MetObs - a Python toolkit for using non-traditional meteorological observations elmada: Dynamic electricity carbon emission factors and prices for Europe eixport: An R package to export emissions to atmospheric models 3dfier: automatic reconstruction of 3D city models autumn: A Python library for dynamic modelling of captured CO_2 cost potential curves |
@kthyng What would be the next steps for the review ? Is it to contact reviewers ? #7337 (comment) |
@lionel42 Ah sorry I thought I had wrapped up the checklist already. No, the next step is to find your editor, which you are already on the waitlist for. Thanks. |
@mengqi-z Can you edit this submission? |
@editorialbot invite @mengqi-z as editor |
Invitation to edit this submission sent! |
@editorialbot assign me as editor |
Assigned! @mengqi-z is now the editor |
Hi @lionel42, I will be the handling editor of your submission. Once we secure at least two reviewers, we’ll begin the review process. Please don’t hesitate to reach out if you have any questions at any point. Thank you! |
👋 @jcla490 @dostuffthatmatters @einaraz - Would any of you be available to review this submission for JOSS? JOSS uses a checklist-driven review process, which you can find here: https://joss.readthedocs.io/en/latest/review_criteria.html |
Hi @mengqi-z , Yes, I am happy to review it! |
@dostuffthatmatters - Wonderful! Thanks so much! |
@editorialbot add @dostuffthatmatters as reviewer |
@dostuffthatmatters added to the reviewers list! |
Hi @mengqi-z, thanks for the invite! I would be happy to review it as well! |
@einaraz - Thank you for taking on this review! |
@editorialbot add @einaraz as reviewer |
@einaraz added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #7509. |
Submitting author: @lionel42 (Lionel Constantin)
Repository: https://github.com/C2SM-RCM/emiproc
Branch with paper.md (empty if default branch): joss
Version: v2.1
Editor: @mengqi-z
Reviewers: @dostuffthatmatters, @einaraz
Managing EiC: Arfon Smith
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @lionel42. Currently, there isn't a JOSS editor assigned to your paper.
@lionel42 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: