-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: MetObs - a Python toolkit for using non-traditional meteorological observations #5916
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
Review checklist for @ZeitsperreConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi there! Thanks for reaching out to me. I'll have some time in the next few weeks to look at this, ideally by October 15th. All the best! |
I will take a look over the weekend. |
Review checklist for @ashwinvisConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I'm still working on my review checklist, but I've opened a few issues to help with the goals that I think still need to be met (perhaps @ashwinvis agrees?). Will try to finish everything this coming week. |
I am stuck with the review, because as mentioned in the issue, I cannot run the software without example data. Thus verifying the functionality and some other checks will have to wait until it is resolved. |
The fix broke the docs, I believe. Waiting for it again... vergauwenthomas/MetObs_toolkit#394 |
The docs are back online. |
I tried to verify the functionality of the software today and I realize that a key attractive feature of this software which is gap-filling relies on Google Earth Engine to access ERA5 reanalysis dataset, a choice which severely restricts the usability (and to some extent the openness) of the software. While the use of proprietary software IDEs have been mentioned in the JOSS docs, I ask what is the stance for reliance on proprietary network services, @hugoledoux ? Also I should ask @vergauwenthomas why did you opt for Google Earth Engine for a dataset easily accessible via Copernicus? Would it be easy to add support for Copernicus's Python API https://climate.copernicus.eu/climate-reanalysis |
Other comments:
|
@ashwinvis, this is indeed a relevant topic. At the beginning of this project, I considered using the Copernicus API, but the Google Earth Engine integration seems a better choice to me because of:
Since the use of the GEE is limited to 1) static geospatial datasets and 2) time-series, I have never reached the limit of the free computational-units. If you feel like including the Copernicus API is a valuable addition, I can open a discussion on this. |
FYI, I have created a new label I will make a priority of these issues and try to solve them asap. |
for the version it's ultimately up to you, but I think it might be an idea to bump to a minor version with all the changes made during the JOSS process. I would suggest v0.2.0, this makes it clearer. For the authors, you added some categories and that mangles the reference and only lists you an as author, can you remove those categories? Researchers + Supervisor. I'm glad you enjoyed JOSS! Consider adding your name to the potential list of reviewers also: https://reviewers.joss.theoj.org/ (I didn't know it was possible, so I learned that today). |
I have bumped it to v0.2.0. I had to create a new DOI (because there were still some references to `v0.1.3-joss', which i could not change). You can find it here: 10.5281/zenodo.10794417 And as @hugoledoux pointed out, i have changed the co-authors and the citations seem oke now: Vergauwen, T., Vieijra, M., Covaci, A., Jacobs, A., Top, S., Dewettinck, W., Vandelanotte, K., Hellebosch, I., & Caluwaerts, S. (2024). MetObs - a Python toolkit for using non-traditional meteorological observations (v0.2.0). Zenodo. https://doi.org/10.5281/zenodo.10794417 |
@editorialbot set 10.5281/zenodo.10794417 as archive |
Done! archive is now 10.5281/zenodo.10794417 |
@editorialbot set v0.2.0 as version |
Done! version is now v0.2.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5102, then you can now move forward with accepting the submission by compiling again with the command |
Great! My steps are:
|
Good to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @vergauwenthomas! Many thanks to editor @hugoledoux and reviewers @ashwinvis and @Zeitsperre for your hard work, time, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @vergauwenthomas (Thomas Vergauwen)
Repository: https://github.com/vergauwenthomas/MetObs_toolkit
Branch with paper.md (empty if default branch): paper
Version: v0.2.0
Editor: @hugoledoux
Reviewers: @ashwinvis, @Zeitsperre
Archive: 10.5281/zenodo.10794417
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ashwinvis & @Zeitsperre, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @Zeitsperre
📝 Checklist for @ashwinvis
The text was updated successfully, but these errors were encountered: