You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Packaged data is kind of enormous: The PyPI wheel/sources are around 13 MB when archive is inflated, with the majority of that space being used by a Shapefile. Is there a way of fetching a subset of that data remotely, maybe? To help bring down the space used, the wheel should only package the data needed to run (not test/demonstrate) the library.
.readthedocs.yml - The os could be updated to ubuntu-22.04
Linting
The repository has a disabled black action. Have you considered using pre-commit or pre-commit.ci?
The comments here aren't necessarily blocking, but it would be good to implement some of these suggestions:
pyproject.toml
file:documentation
URL points to the documentation page ofPoetry
environment.yml
: It might be just my experience, but unless you have a specific implementation (e.g. a production-level docker service), you shouldn't need to pin the binaries to their hashes. I can see this being a problem for some platforms/systems down the line. Please correct me if I'm wrong! #435.readthedocs.yml
- Theos
could be updated toubuntu-22.04
black
action. Have you considered using pre-commit or pre-commit.ci?pyproject.toml
file could be used to set the linting and style configuration for the code base (usingflake8
orruff
). (example from a project I maintain calledxclim
: https://github.com/Ouranosinc/xclim/blob/2d981abc8291645da235c52479162953ef2ab6d6/pyproject.toml#L215)pyproject.toml
file could be cleaned up a bit (https://github.com/macisamuele/language-formatters-pre-commit-hooks)Context: openjournals/joss-reviews#5916
The text was updated successfully, but these errors were encountered: