-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Thresholdmann: A Web tool for interactively creating adaptive thresholds to segment MRI data. #6336
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
👋🏼 @katjaq @sneakers-the-rat @62442katieb @anibalsolon, this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@adamltyson) if you have any questions/concerns. |
Review checklist for @sneakers-the-ratConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Issues and PRs
Review CommentsIf there is one thing you can always say about @katjaq , @r03ert0 , and @ntraut 's code it's that it does exactly what it says it does with style, simplicity, and solidity. Thanks to the authors for this lovely tool. I am only familiar with working with fMRI data being a huge hassle of gigantic packages and cumbersome GUIs, and so this tool that you can hold in the palm of your hand and run anywhere is an absolute treat. I am a huge fan of the author's small web, single purpose tool philosophy, and this is another great entry in that saga. I have said this a number of times in the issues, but I think this kind of web development is especially lovely to see in an era of increasingly bloated javascript frameworks that are difficult to maintain and reverse engineer. for this tool to literally be deployed as is from a static web server - not even a build stage! - shows how much more legroom the web browser as programming environment has. The code is capable, concise, and correct. very well done. Docs are good, tests are good, all claims made in the paper easily validated, fundamentals are sound. The area of growth i have suggested for the authors is to use some of those tools to extend the functional modularity of their work into a bit more fluid programmatic modularity. They make excellent use of their prior work with mriviewer and muijs, but the use of global page state does put a little bit of a cap on how the excellent work they have done here can be reused. One of the virtues of their very modular approach is that it naturally lends itself to compositionality - it's already possible to mix and match their tools as part of a researcher's workflow, the next level would be to be able to mix and match them in downstream tools. I have written a skeleton draft of a transitional path there in an above linked PR for the authors to take or leave. Even without tools like webpack, ES6 modules are well supported by browsers, so the authors can keep the dream of the low-fi but high-function read/write web alive and make a lovely little ecosystem that builds and builds and builds on itself! I don't have much more to say since the work speaks for itself. Thanks again to the authors for their work, i will continue to jump at the chance to use and look at any work y'all do - always a treat. They have addressed all my suggestions and i wholeheartedly endorse this for JOSS! |
Review checklist for @anibalsolonConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Issues and PRs
|
Review checklist for @62442katiebConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @sneakers-the-rat, @anibalsolon, @62442katieb it looks like you've all started your reviews. Please let me know if I can be of any assistance! |
Just a quick remidner that we aim to have reviews completed within 2-4 weeks. Do you have an idea when you'll have time to look into this? @sneakers-the-rat it looks like you've raised issues on the software repo (thanks!) and are awaiting a response. Let me know if I can help with anything. Thanks! |
Done! archive is now 10.5281/zenodo.11080336 |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
No declaration for attribute displaystyle of element mfrac
No declaration for attribute displaystyle of element mfrac |
Hello @adamltyson . Yeyyyyy, thank you so much for setting publication in motion 😍 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5285, then you can now move forward with accepting the submission by compiling again with the command |
Thanks @katjaq, that seems to have fixed it! I'll hand this over to the EiC for the final checks. |
@katjaq as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. Everything seems to be in order, the only thing I've noticed is that your archive page does not list the license. Can you check (but attempting to manually edit the listing) if you can add your software license? Here is one for a different project, and as you can see it will be listed under "Rights": https://zenodo.org/records/10278296. |
Hello @Kevin-Mattheus-Moerman . Thank you very much for your feedback. Sorry for my misunderstanding. I thought it was enough that the license appears in the archive. The license is now listed in our Zenodo entry. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@katjaq congratulations on this JOSS publication! Thanks for editing this work @adamltyson Also a special thank you to the reviewers: @sneakers-the-rat, @62442katieb, @anibalsolon !!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks @Kevin-Mattheus-Moerman. Congratulations @katjaq, and thank you @sneakers-the-rat, @anibalsolon @62442katieb! |
Wouuuhouuuu! Thank you @adamltyson and @Kevin-Mattheus-Moerman ! 😍 That was a fantastic review experience! Thank you so much @sneakers-the-rat , @anibalsolon and @62442katieb 🌟 |
Thank you everyone for your work! Our tool is much better now thanks to your help :D
…On May 3 2024, at 10:09 am, katja heuer ***@***.***> wrote:
Wouuuhouuuu! Thank you @adamltyson (https://github.com/adamltyson) and @Kevin-Mattheus-Moerman (https://github.com/Kevin-Mattheus-Moerman) ! 😍 That was a fantastic review experience! Thank you so much @sneakers-the-rat (https://github.com/sneakers-the-rat) , @anibalsolon (https://github.com/anibalsolon) and @62442katieb (https://github.com/62442katieb) 🌟
❤️
—
Reply to this email directly, view it on GitHub (#6336 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AARUETCGPX4NXSWUMGX2GSDZANA4JAVCNFSM6AAAAABC7PNGUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGUZDCMBWGQ).
You are receiving this because you were mentioned.
|
Submitting author: @katjaq (Katja Heuer)
Repository: https://github.com/neuroanatomy/thresholdmann
Branch with paper.md (empty if default branch): joss-paper-branch
Version: v.1.0.0
Editor: @adamltyson
Reviewers: @sneakers-the-rat, @62442katieb, @anibalsolon
Archive: 10.5281/zenodo.11080336
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@sneakers-the-rat & @62442katieb & @anibalsolon, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @adamltyson know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @sneakers-the-rat
📝 Checklist for @anibalsolon
📝 Checklist for @62442katieb
The text was updated successfully, but these errors were encountered: