Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss][ui] control points contrast #35

Closed
anibalsolon opened this issue Apr 19, 2024 · 1 comment
Closed

[joss][ui] control points contrast #35

anibalsolon opened this issue Apr 19, 2024 · 1 comment

Comments

@anibalsolon
Copy link

Part of: openjournals/joss-reviews#6336

Extracted from the main manuscript:
image

And from the main example:
image

I find that, for some cases, control points are hard to see. According to a contrast check, it would fail the WCAG compliance.
https://webaim.org/resources/contrastchecker/

image

Although much hard to provide a full accessibility, I believe improving the points visibility would be a great modification to the tool. For example, adding a lighter border to the point or making it blink upon clicking on it on the right panel, or even drawing the control point in the canvas, allowing it to compute the most optimal contrasting color.

image

@katjaq
Copy link
Member

katjaq commented Apr 27, 2024

Thank you for this feedback and the linked resource which will keep in mind also for future applications :)
We implemented a thin solid white border around each control point for better visibility in commit #4f4185b as suggested.

@katjaq katjaq closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants