-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: TauFactor 2: A GPU accelerated python tool for microstructural analysis #5358
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @ma-sadeghiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @alexsquiresConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @stke9 before raising any technical points as issues on the repo itself I just wanted to check an admin point. I'm certain there is a straightforward explanation for this, I just want to do due diligence! With regards to the point:
Could you clarify the contributions of the paper authors as going off the repo alone it is not clear. |
I've been over the code, and my comments are included in:
I'm very happy to recommend taufactor 2 for publication if these can be addressed. |
Hi Alex, thanks so much for all your comments, was so useful to have some fresh eyes on the repo. WRT authorship, we have added the following: 'SK wrote the base, periodic and multiphase solvers with input from IS. IS wrote the electrode solver, metric calculations and documentation, and also performed speed tests for other software packages. The project was supervised by SC, and based on his original MATLAB tool. All authors contributed to the writing and editing of the manuscript.' I moved lots of the code from a different repo i was working in to our groups gh, which is why i have v few contributions! Let us know how the speed testing is coming along! |
I suspected that or similar may have been the case, thanks for clarifying. Aiming to complete the speed test by the end of tomorrow, and then I will have checked everything off. |
Just a heads up as I said I would finish this today, I have been waiting for one of our institutions machine with lots of GPUs to come back online after some down time to run my tests. It's back and they are in the queue, hopefully they will run tonight, and then I can check this off! |
No worries, let us know if you come across any issues! |
just this:
tldr-group/taufactor#74 (comment)
…On Thu, 18 May 2023 at 10:49, stke9 ***@***.***> wrote:
No worries, let us know if you come across any issues!
—
Reply to this email directly, view it on GitHub
<#5358 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMK74RRAK3FUDLLABQ5XA3XGXWEHANCNFSM6AAAAAAW3NPGDM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @zhubonan, I'm done! Looks good to me. |
Sorry for the wait, I'm about to finish my review, I'll update this thread. |
@ma-sadeghi how is it going? BTW, If you have any update/concerns, please feel free to post them here. |
@ma-sadeghi Just want to give a gentle reminder as the review is pending. I am looking forward to your comments. Would you be able to finish it in two weeks? If not, it would be great if you can let me know the time frame. Thanks a lot. |
@zhubonan I really apologize that I dropped the ball on this. I'm swamped at the moment, but that's no excuse. Anyway, I will finish this in two weeks, I almost want to make a promise to do it sooner, but for the sake of not embarrassing myself again, let's aim for the two week window. Thank you so much for your patience :) |
Thank you for your patience :) I've reviewed TauFactor and here's comments:
@stke9 TauFactor is a very useful piece of software. Thanks for making it available to the public! |
@ma-sadeghi Thanks for doing the review. |
Thanks @ma-sadeghi really useful comments! Most issues resolved I think, just two to look (see your above list of issues). Cheers! |
|
No declaration for attribute displaystyle of element mfrac
No declaration for attribute displaystyle of element mfrac
No declaration for attribute displaystyle of element mfrac |
@openjournals/dev can you help here ☝️ |
The errors come from the math equations code using displaymode with |
Have merged the PR! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4453, then you can now move forward with accepting the submission by compiling again with the command |
All looks good to us! |
@stke9 I have checked the paper, this review, your repository, and the archive, and all seems in order. However I did find a minor typo in the paper which you can fix:
Next I noticed you say |
The 'calaculated' typo has been fixed by the latest PR. The plural in materials is intentional, 'materials science' and 'materials characterisation' is our preferred syntax. |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@stke9 congratulations on this JOSS publication! Thanks for editing this one @zhubonan! And a special thanks to the reviewers @alexsquires and @ma-sadeghi ! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @stke9 (Steven Kench)
Repository: https://github.com/tldr-group/taufactor
Branch with paper.md (empty if default branch): main
Version: v1.1.0
Editor: @zhubonan
Reviewers: @alexsquires, @ma-sadeghi
Archive: 10.5281/zenodo.8177306
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@alexsquires & @ma-sadeghi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @zhubonan know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @ma-sadeghi
📝 Checklist for @alexsquires
The text was updated successfully, but these errors were encountered: