Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Some docstrings of the unit tests needs revision #80

Closed
ma-sadeghi opened this issue Jun 28, 2023 · 1 comment
Closed

JOSS review: Some docstrings of the unit tests needs revision #80

ma-sadeghi opened this issue Jun 28, 2023 · 1 comment

Comments

@ma-sadeghi
Copy link

This is very minor, just for completeness: Could you please revise the docstrings of the unit tests? Some of them don't reflect what the unit test does like:

def test_taue_deadend():
"""Run solver on a strip of ones, 1/4 volume of total"""

and

def test_taue_throughpore():
"""Run solver on a strip of ones, 1/4 volume of total"""

@stke9
Copy link
Contributor

stke9 commented Jun 29, 2023

Done and added a few missing, thanks!

@stke9 stke9 closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants