Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Python version >= 3.9 #77

Closed
ma-sadeghi opened this issue Jun 28, 2023 · 4 comments
Closed

JOSS review: Python version >= 3.9 #77

ma-sadeghi opened this issue Jun 28, 2023 · 4 comments

Comments

@ma-sadeghi
Copy link

NumPy has dropped support for Python 3.8 on April 14, 2023. There are some places that unsupport Python versions have been used: setup.py, tox.ini, etc.

@stke9
Copy link
Contributor

stke9 commented Jun 29, 2023

Can you elaborate on why this is a problem - users can have compatible versions of python and numpy, we don't necessarily want to force them to use python 3.9 right? I have updated tox to include 3.9 option though!

@ma-sadeghi
Copy link
Author

ma-sadeghi commented Jun 29, 2023

I totally agree that we shouldn't force people to not use unsupported Python versions. It's just that unsupported Python/NumPy versions pose potential security risks/bugs that won't be patched. So, it's a good practice to encourage users to use the Python/NumPy versions that are still getting patched. Also, as more libraries drop support for Python 3.8, users may face compatibility issues.

As a side note, it just occured to me that since you've already released v1.0.0, dropping support for unsupported Python/NumPy versions wouldn't affect existing users (since it'll be on the dev branch). Once you make a new release on PyPI, it'll be enforced.

Regarding setup.py, could you add Python 3.10 as well? I'm asking because the default Python version on a freshly installed Ubuntu and also the Anaconda Python distribution is 3.10.

@ma-sadeghi
Copy link
Author

Just to clarify, this is a minor comment, and I'll leave it up you in case you're not convinced :)

@isaacsquires
Copy link
Member

Hi, we have included 3.9 and 3.10 in our latest release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants