[joss][tests] Use playwright for testing multiple browsers #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: openjournals/joss-reviews#6336
before
hook times out #18npm test
ran with full success.these changes are adding test cases
Problem
Puppeteer is made for chromium-browsers only. Google is trying to own the web via chrome. Part of the problem is a constant shifting target that breaks other browsers. Ergo testing against other browsers is important for a free web.
This PR
playwright
- which is developed by the same team as puppeteer for testing across browsersSplit into two commits so it's easier to see changes - first commit is just substantive changes, and second commit is linting.
Really simple changes, just wrap tests in an additional
forEach
+describe
block that tests with a given browser as described in the mocha docs. Use mocha global fixtures again as described in the docs