Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release 5.38.0 #3177

Merged
merged 19 commits into from
Dec 14, 2021
Merged

build: release 5.38.0 #3177

merged 19 commits into from
Dec 14, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Dec 13, 2021

Improvements

  • feat: Add prefill support for singpass forms with redirects #3139
  • feat: enable M series FIN validation #3162
  • feat: twilio sms webhook with celebrate validation #3157
  • fix(ci/deploy): set truncated description during ELB deployment #3147
  • chore: allow forked PRs to run our github action workflows #3175
  • chore: remove e2e tests #3146

Dep Updates

  • chore(deps-dev): bump @types/lodash from 4.14.177 to 4.14.178 #3163
  • chore(deps-dev): bump core-js from 3.19.2 to 3.19.3 #3149
  • chore(deps-dev): bump jest-mock-axios from 4.4.1 to 4.5.0 #3150
  • chore(deps-dev): bump typescript from 4.5.2 to 4.5.3 #3174
  • fix(deps): bump @sentry/browser from 6.15.0 to 6.16.0 #3158
  • fix(deps): bump @sentry/browser from 6.16.0 to 6.16.1 #3170
  • fix(deps): bump @sentry/integrations from 6.15.0 to 6.16.0 #3161
  • fix(deps): bump @sentry/integrations from 6.16.0 to 6.16.1 #3169
  • fix(deps): bump aws-sdk from 2.1043.0 to 2.1044.0 #3160
  • fix(deps): bump aws-sdk from 2.1044.0 to 2.1046.0 #3173
  • fix(deps): bump body-parser from 1.19.0 to 1.19.1 #3172

dependabot bot and others added 19 commits December 6, 2021 17:50
@dependabot
chore(deps-dev): bump jest-mock-axios from 4.4.1 to 4.5.0 (#3150)
798ba83 
Bumps [jest-mock-axios](https://github.com/knee-cola/jest-mock-axios) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/knee-cola/jest-mock-axios/releases)
- [Changelog](https://github.com/knee-cola/jest-mock-axios/blob/master/CHANGELOG.md)
- [Commits](https://github.com/knee-cola/jest-mock-axios/commits)

---
updated-dependencies:
- dependency-name: jest-mock-axios
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump core-js from 3.19.2 to 3.19.3 (#3149)
1e8078d 
Bumps [core-js](https://github.com/zloirock/core-js) from 3.19.2 to 3.19.3.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](zloirock/core-js@v3.19.2...v3.19.3)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@frankchn @karrui
feat: Add prefill support for singpass forms with redirects (#3139)
46c7c84 
* [feat] Add prefill support for singpass forms with redirects

* fix tests

* fix tests part 2

* address code review comments

* fix type

* add action to logger.warn

* address code review round 2 comments

* fix type error

* do not interpolate the string

* rename err to e

Co-authored-by: Kar Rui Lau <[email protected]>
@karrui
fix(ci/deploy): set truncated description during ELB deployment (#3147)
13b8ab6 
* fix(ci/deploy): set truncated description during deployment

We use git commit messages as the description for our ELB deployment.
AWS has a hard limit of 200 characters, which may exceed when a commit message is longer (like this) and throw an error. This commit attempts to fix that by truncating the commit message if it is longer than 200 characters.

* fix(ci/deploy): wrap string to truncate in quotes, lower char limit

We use git commit messages as the description for our ELB deployment.
AWS has a hard limit of 200 characters, which may exceed when a commit message is longer (like this) and throw an error. This commit attempts to fix that by truncating the commit message if it is longer than 180 characters.

* fix: add quotes to truncated description
@tshuli
Merge pull request #3153 from opengovsg/release-5.37.1-hotfix
440835a 
build: merge release 5.37.1 into develop
@dependabot
fix(deps): bump @sentry/browser from 6.15.0 to 6.16.0 (#3158)
e47baf2 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.15.0 to 6.16.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.15.0...6.16.0)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.1043.0 to 2.1044.0 (#3160)
01480c8 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1043.0 to 2.1044.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1043.0...v2.1044.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/integrations from 6.15.0 to 6.16.0 (#3161)
7bb1ce9 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.15.0 to 6.16.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.15.0...6.16.0)

---
updated-dependencies:
- dependency-name: "@sentry/integrations"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@zatkiller
feat: enable M series FIN validation (#3162)
62ada30
@zatkiller
feat: twilio sms webhook with celebrate validation (#3157)
cccacdd 
* feat: Add twilio webhook endpoint

* test: add status callback to sms service tests

* fix: cast map and mapError result to true and defined error types

* refactor: remove explicit typecast

* feat: add logging of non-errors

* fix: logger import path

* refactor: remove twilio service and conditional for error logging

* fix: remove ngrok route

* test: Add integration test for twilio webhook

* tests: Add twilio webhook tests

* docs: update endpoint response documentation

* docs: update JS docs for twilioSmsUpdates

* docs: add comment to sync callback routes

* fix: Switch twilio webhook validator to use celebrate

* test: add twilio signature to webhook test cases

* fix: add missing status callback and tests

* feat: set celebrate to unknown() to handle any key extensions

* test: remove config.appUri
@karrui
chore: remove e2e tests (#3146)
bdcdd1d 
* feat: remove tests/end-to-end folders

* chore(ci): remove test-e2e ci job

* feat(package.json): remove testcafe packages and related scripts

* fix: add missing lodash types package due to removal of testcafe

* docs: update README entry on end to end tests

* chore(ci/mergify): remove test-e2e condition to auto-merge
@dependabot
chore(deps-dev): bump @types/lodash from 4.14.177 to 4.14.178 (#3163)
dcefb9a 
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.177 to 4.14.178.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

---
updated-dependencies:
- dependency-name: "@types/lodash"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/integrations from 6.16.0 to 6.16.1 (#3169)
4c0ef7c 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.16.0 to 6.16.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.16.0...6.16.1)

---
updated-dependencies:
- dependency-name: "@sentry/integrations"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/browser from 6.16.0 to 6.16.1 (#3170)
ff148b9 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.16.0 to 6.16.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.16.0...6.16.1)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.1044.0 to 2.1046.0 (#3173)
2d68153 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1044.0 to 2.1046.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1044.0...v2.1046.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump body-parser from 1.19.0 to 1.19.1 (#3172)
179d4be 
Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.19.0 to 1.19.1.
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.19.0...1.19.1)

---
updated-dependencies:
- dependency-name: body-parser
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump typescript from 4.5.2 to 4.5.3 (#3174)
37bddac 
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.5.2...v4.5.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@karrui
chore: allow forked PRs to run our github action workflows (#3175)
5f7965d
@tshuli
chore: bump version to 5.38.0
8061e99
@tshuli
Copy link
Contributor Author

tshuli commented Dec 14, 2021 •
edited
Loading

Tests

NRIC M series
@tshuli

  • Create a NRIC field on a form
  • Type in M1234567K (or any other valid M series FIN value), there should be no warning displayed in the browser
  • Submit a response to the form with M1234567K as the value in the NRIC field, no error should occur

@tshuli
Copy link
Contributor Author

tshuli commented Dec 14, 2021 •
edited
Loading

Twilio SMS webhook
@tshuli

  • Add a mobile number field to any form and enable Sms verification for the field
  • Enter mobile number and click verify to receive OTP
  • Check AWS console to see sms status webhook is logged under meta.action twilioSmsUpdates

@tshuli
Copy link
Contributor Author

tshuli commented Dec 14, 2021 •
edited
Loading

Singpass prefill

  • Verify that Singpass logins work with a standard form as well as a form with pre-filled parameters.

@tshuli tshuli temporarily deployed to uat December 14, 2021 05:47 Inactive
@tshuli tshuli merged commit fb4e4f9 into release Dec 14, 2021
@tshuli tshuli deleted the release-5.38.0 branch December 14, 2021 06:43
@tshuli tshuli restored the release-5.38.0 branch December 14, 2021 06:43
@karrui karrui deleted the release-5.38.0 branch December 15, 2021 02:54
@karrui karrui restored the release-5.38.0 branch December 20, 2021 06:59
@karrui karrui deleted the release-5.38.0 branch December 20, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tshuli @karrui @frankchn @zatkiller