chore: remove e2e tests #3146
Merged
chore: remove e2e tests #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
approved these changes
Dec 9, 2021
Merged
tshuli
added a commit
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR removes e2e tests, as their flakeyness has only stopped us from pushing/merging quickly and has not actually caught any bugs (that would not have been caught during manual release testing).
(Another strong factor is due to mongoose v6 upgrade being blocked due to TestCafe not playing nice, and I really do not want to dedicate more hours to fixing something that we will be replacing in a couple weeks/months. See #3093)
This PR is a prelude to replacing the e2e tests when React migration comes about, which is tracked by #3145.
Related to #3145.
Solution
Features:
Tests
E2e tests removed
Deploy Notes