chore: remove e2e tests (#3146)

* feat: remove tests/end-to-end folders

* chore(ci): remove test-e2e ci job

* feat(package.json): remove testcafe packages and related scripts

* fix: add missing lodash types package due to removal of testcafe

* docs: update README entry on end to end tests

* chore(ci/mergify): remove test-e2e condition to auto-merge

.github/mergify.yml

@@ -6,7 +6,6 @@ pull_request_rules:
       - check-success~=build
       - check-success~=test-frontend
       - check-success~=test-backend
-      - check-success~=test-e2e
       - check-success~=Analyze # CodeQL / Analyze
       - check-success~=CodeQL # CodeQL code scanning results
       - check-success~=GitGuardian
@@ -26,7 +25,6 @@ pull_request_rules:
       - check-success~=build
       - check-success~=test-frontend
       - check-success~=test-backend
-      - check-success~=test-e2e
       - check-success~=Analyze # CodeQL / Analyze
       - check-success~=CodeQL # CodeQL code scanning results
       - check-success~=GitGuardian

.github/workflows/ci.yml

@@ -62,24 +62,6 @@ jobs:
       - run: npm ci
       - run: npm run build
 
-  test-e2e:
-    needs: lint
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - name: Use Node.js
-        uses: actions/setup-node@v1
-        with:
-          node-version: '14.x'
-      - name: Load Node.js modules
-        uses: actions/cache@v2
-        with:
-          # npm cache files are stored in `~/.npm` on Linux/macOS
-          path: ~/.npm
-          key: ${{ runner.OS }}-node-${{ hashFiles('**/package-lock.json') }}
-      - run: npm ci
-      - run: npm run test-e2e
-
   test-frontend:
     needs: lint
     runs-on: ubuntu-latest

README.md

@@ -145,17 +145,7 @@ npm run test-ci
 
 #### End-to-end tests
 
-```bash
-npm run test-e2e
-```
-
-will build both the frontend and backend then run our end-to-end tests. The tests are located at [`tests/end-to-end`](./tests/end-to-end). You will need to stop the Docker dev container to be able to run the end-to-end tests.
-
-If you do not need to rebuild the frontend and backend, you can run
-
-```bash
-npm run test-e2e-ci
-```
+Removed in [#3146](https://github.com/opengovsg/FormSG/pull/3146). Will be reimplemented when the React app is ready.
 
 ## Architecture
 

package.json

@@ -29,12 +29,6 @@
     "dev": "docker-compose up --build",
     "docker-dev": "npm run build-frontend-dev:watch & ts-node-dev --respawn --transpile-only --inspect=0.0.0.0 --exit-child -r dotenv/config -- src/app/server.ts",
     "test": "npm run test-backend && npm run test-frontend",
-    "download-binary": "node tests/end-to-end/helpers/get-mongo-binary.js",
-    "test-e2e": "npm run test-e2e-build && npm run test-e2e-ci",
-    "test-e2e-build": "npm run build-backend && npm run build-frontend-dev",
-    "test-e2e-ci": "env-cmd -f tests/.test-env --use-shell \"npm run download-binary && npm run testcafe-command\"",
-    "testcafe-command": "testcafe --skip-js-errors -c 2 chrome:headless ./tests/end-to-end --app \"npm run test-e2e-server\" --app-init-delay 10000",
-    "test-e2e-server": "concurrently --success last --kill-others \"mockpass\" \"maildev\" \"node dist/backend/src/app/server.js\" \"node ./tests/mock-webhook-server.js\"",
     "lint-code": "eslint src/ --quiet --fix",
     "lint-style": "stylelint '*/**/*.css' --quiet --fix",
     "lint-html": "htmlhint && prettier --write './src/public/**/*.html' --ignore-path './dist/**' --loglevel silent",
@@ -181,6 +175,7 @@
     "@types/ip": "^1.1.0",
     "@types/jest": "^27.0.3",
     "@types/json-stringify-safe": "^5.0.0",
+    "@types/lodash": "^4.14.177",
     "@types/mongodb": "^3.6.20",
     "@types/mongodb-uri": "^0.9.1",
     "@types/node": "^14.18.0",
@@ -243,7 +238,6 @@
     "supertest": "^6.1.6",
     "supertest-session": "^4.1.0",
     "terser-webpack-plugin": "^1.2.3",
-    "testcafe": "=1.15.1",
     "ts-essentials": "^9.0.0",
     "ts-jest": "^26.5.6",
     "ts-loader": "^7.0.5",

shared/package.json

@@ -13,6 +13,7 @@
     "zod": "^3.7.2"
   },
   "devDependencies": {
+    "@types/lodash": "^4.14.177",
     "@typescript-eslint/eslint-plugin": "^4.28.2",
     "@typescript-eslint/parser": "^4.28.2",
     "eslint-config-prettier": "^8.3.0",

src/app/modules/bounce/__tests__/bounce.service.spec.ts

@@ -2,7 +2,7 @@
 import axios from 'axios'
 import { ObjectId } from 'bson'
 import crypto from 'crypto'
-import dedent from 'dedent'
+import dedent from 'dedent-js'
 import { cloneDeep, omit, pick } from 'lodash'
 import mongoose from 'mongoose'
 import { errAsync, okAsync } from 'neverthrow'