chore: allow forked PRs to run our github action workflows #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tshuli
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
lgtm!
as discussed:
- update
Fork pull request workflows from outside collaboratorsto require approval for all outside contributors (done) - note that
Once a collaborator with write access has reviewed the changes, they can approve the workflows to run for the current commit only. If the pull request is updated to a new commit, a new approval will be required.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Forked PRs (see #2819) seem to not be able to run our Github Action workflows due to missing trigger conditions.
This results in a bad experience for any open source contributors and should be fixed.
This PR adds a new
pull_request_targetworkflow trigger to our CI workflow config.Deploy Notes
New
pull_request_targettrigger on ourCIGithub workflow.