Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable M series FIN validation #3162

Merged
merged 1 commit into from
Dec 8, 2021
Merged

feat: enable M series FIN validation #3162

merged 1 commit into from
Dec 8, 2021

Conversation

zatkiller
Copy link
Contributor

@zatkiller zatkiller commented Dec 8, 2021 •
edited
Loading

Problem

Currently, M series FIN/NRIC validation has been implemented but is not being used.

Closes #3155

Manual Tests

  • Create a NRIC field on a form
  • Type in M1234567K (or any other valid M series FIN value), there should be no warning displayed in the browser
  • Submit a response to the form with M1234567K as the value in the NRIC field, no error should occur

@zatkiller zatkiller requested a review from karrui December 8, 2021 02:06
karrui
karrui approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please add manual tests for release testing

@karrui karrui merged commit 62ada30 into develop Dec 8, 2021
@karrui karrui deleted the feat/use-m-series-validation branch December 8, 2021 03:10
@tshuli tshuli mentioned this pull request Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use M series FIN/NRIC validation function
2 participants
@zatkiller @karrui