Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge develop to form-v2/develop #2533

Merged
merged 204 commits into from
Aug 10, 2021
Merged

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 5, 2021

Problem

Part of the periodic merges from develop into this feature branch

LoneRifle and others added 30 commits June 23, 2021 10:52
Allow Form to be configured using a .env file, read by dotenv and
populated into `process.env`.

- `npm install dotenv`
- pick up the `.env` config using dotenv just before we invoke
  the application
- remove `.env` entry from `.dockerignore`
- use an .ebextensions config to create an .env from Parameter Store
  - determine the environment name by looking at container config files
    directly [1]
- mount the .env into /opt/formsg/.env

References:
[1]: https://aws.amazon.com/premiumsupport/knowledge-center/view-environment-properties-elastic-beanstalk/
feat(config): support config via dotenv, use EB to create file
Bumps [optimize-css-assets-webpack-plugin](https://github.com/NMFR/optimize-css-assets-webpack-plugin) from 5.0.3 to 5.0.8.
- [Release notes](https://github.com/NMFR/optimize-css-assets-webpack-plugin/releases)
- [Commits](NMFR/optimize-css-assets-webpack-plugin@v5.0.3...v5.0.8)

---
updated-dependencies:
- dependency-name: optimize-css-assets-webpack-plugin
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.932.0 to 2.933.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.932.0...v2.933.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.933.0 to 2.935.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.933.0...v2.935.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: in "Edit Welcome", move "Color Theme" to btwn "Logo" and "Time taken for..." and add rows="12" to "Instructions..." textarea

* chore: run formatter
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.7.2 to 6.8.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.7.2...6.8.0)

---
updated-dependencies:
- dependency-name: "@sentry/integrations"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2270)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.28.0 to 4.28.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.28.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.7.2 to 6.8.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.7.2...6.8.0)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
this fixes the bug where the targetFormId was incorrectly retrieving the first 24 characters of the URL, which will fail as the API URLs have changed to be more semantic.

instead, take in the targetFormId directly as we already know the formId.
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.28.0 to 4.28.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.28.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: move MB to shared/constants and use MB throughout app

* ref: lint attachmentValidator and use relative import

Co-authored-by: Kar Rui Lau <[email protected]>
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.15.1 to 3.15.2.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.15.2/packages/core-js)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.935.0 to 2.936.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.935.0...v2.936.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [coveralls](https://github.com/nickmerwin/node-coveralls) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/nickmerwin/node-coveralls/releases)
- [Commits](nickmerwin/node-coveralls@v3.1.0...3.1.1)

---
updated-dependencies:
- dependency-name: coveralls
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-node-dev](https://github.com/whitecolor/ts-node-dev) from 1.1.6 to 1.1.7.
- [Release notes](https://github.com/whitecolor/ts-node-dev/releases)
- [Changelog](https://github.com/wclr/ts-node-dev/blob/master/CHANGELOG.md)
- [Commits](wclr/ts-node-dev@v1.1.6...v1.1.7)

---
updated-dependencies:
- dependency-name: ts-node-dev
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor(emails-input): use ng-messages

* fix: fail validation only if responseMode is email

* fix: allow empty array and string for emails key in storage mode
* feat: update response email subject to use #

* feat: update response email body to use Response ID

* feat: update storage mode Data tab to use Response ID

* feat: update storage mode CSV to use Response ID

* feat: update email confirmation PDF to use Response ID

* build: empty commit to trigger build
chore: merge release v5.17.0 back to develop
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.64.0 to 3.65.0.
- [Release notes](https://github.com/twilio/twilio-node/releases)
- [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md)
- [Commits](twilio/twilio-node@3.64.0...3.65.0)

---
updated-dependencies:
- dependency-name: twilio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.6.18 to 3.6.19.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb)

---
updated-dependencies:
- dependency-name: "@types/mongodb"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.936.0 to 2.937.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.936.0...v2.937.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 24 commits August 1, 2021 17:44
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 1.2.3 to 1.3.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v1.2.3...v1.3.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [core-js](https://github.com/zloirock/core-js) from 3.15.2 to 3.16.0.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](zloirock/core-js@v3.15.2...v3.16.0)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.956.0 to 2.958.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.956.0...v2.958.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…shared folder (#2399)

* ref: move submission to shared folder, fix SubmissionCountQueryDto

* ref(client): use relocated shared types in client services

* ref: alias or use new shared types in backend types

* ref(controllers): type params and queries with DTO types
* chore(signin): change "otp" to "OTP" in response

* chore(signin): render Joi error message correctly

* test: update casing in tests
* ref: move billing related types to root shared folder

* ref(server): extend from shared types

* ref(client): use shared types

* feat: remove export for ILogin type
* feat(sms-limiting): sms counts retrieval (#2276)

* feat(sms_count.server.model): adds new isOnboardedAcc key and scripts to add/delete the key

* refactor(sms.types): adds property that checks if a sms is sent using formsg's credentials

* refactor(sms_count.server.model): adds pre-save hook to automatically set property

* feat(sms.types): updated typings of IVerificationsmscount

* test(sms_count.server): fixed tests and added extra tests for isOnboardedAccount

* feat(sms.service): adds new method to retrieve free sms counts of a user

* test(sms.service): adds new unit tests for sms count  retrieval

* test(sms_count.server.model): updated test case for a client using default credentials

* feat(sms.controller): added new sms controller iwth method to retrieve counts and msgsrvcid

fix(sms.controller.ts): added mapRouteError for sms controller

* feat(routes): exposes new route at sms/:userId/:formId

* fix(sms.controller): removed sms count retrieval requiring the userId as it sohuld be for the admin

* refactor(sms): count retrieval no longer required userId

* test(sms.controller): added unit tests for controller method to retrieve counts

* fix(sms.controller): changed to relative imports in spec to avoid e2e tests breaking

* refactor(sms_count): sms service wraps model count documents call

* test(sms.service): reworked tests to account for mocking of db

* refactor(sms.controller): removed extra middleware from sms controller

* test(sms.controller.spec): renamed sms controller's exposed method in tests

* refactor(sms.routes): removed unused sms route

* refactor(sms.controller): changed counts retrieval to be solely focused on counts

* feat(admin-forms.form.routes): adds new route for retrieving free sms ocunts for admin of a form

* refactor(sms_count): shifts default msgsrvcid to be from config, helper method defined in test

* test(sms.controller.spec): updated tests to use mocks

* test(sms_count.server.model.spec): updated db tests to use smsConfig

* fix(v3.routes): removed extra import statement

* refactor(types): renamed smscounts meta and shifted it to api

renamed to smsCountsDto because it is used to transfer data b/w fe and be. against giving it a more
specific name because this is a type signifying a transfer of sms count data. context for what this
sms counts actually means should be given by the caller

* test(sms_count.server.model.spec): updated test to use sms_config

* docs(sms): updated docs for sms counts retrieval in controller and route

* test(sms.service.spec): made tests more explicit

* refactor(admin-form.controller): shifts over handler for count retrieval from sms to admin-form

* test(admin-form.controller.spec): shifts over associated tests

* refactor(sms_count.server.model.spec): changed tests structure

* chore(sms.util): removed unneeded method

* refactor(sms.types): added in docs for retrieveFreeSmsCounts

* fix(admin-forms.form.routes): removed erroneous import

* fix(sms.service): adds error logging

* feat(sms-limiting): prerelease (#2500)

* refactor(admin-form/controller): removed env var being sent and changed quota to be on method

* refactor(sms.types): updated disableSms to use mongoose types; updated typing of verification schema

* fix(sms.config): added missing property
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.22 to 1.9.23.
- [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags)
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.9.22...v1.9.23)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [zod](https://github.com/colinhacks/zod) from 3.6.1 to 3.7.1.
- [Release notes](https://github.com/colinhacks/zod/releases)
- [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md)
- [Commits](https://github.com/colinhacks/zod/commits)

---
updated-dependencies:
- dependency-name: zod
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 2.7.6 to 2.7.7.
- [Release notes](https://github.com/opengovsg/mockpass/releases)
- [Commits](opengovsg/mockpass@v2.7.6...v2.7.7)

---
updated-dependencies:
- dependency-name: "@opengovsg/mockpass"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.28.5 to 4.29.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.29.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: merge v5.22.0 into develop
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.958.0 to 2.959.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.958.0...v2.959.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2524)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.28.5 to 4.29.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.29.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: remove dependency on `path` import in shared folder

may result in wonky behaviour, since `path` is a nodejs module

* ref(file-validation): refactor getInvalidFileExtensionsInZip

to not require currying and be a single function instead

* feat(old-shared): remove now unused FilePlatforms enum

* ref: move src/types/utils to shared/types/utils

* chore: add additional npm packages for root shared folder

in prep for moving src/shared to root shared

* feat: move util/email-domain-validation to root shared folder

* feat: move util/has-prop to root shared folder

* feat: move util/file-validation to root shared folder

* feat: move util/immutable-array-fns to root shared folder

* feat: move util/nric-validation to root shared folder

* feat: move util/phone-num-validation to root shared folder

* feat: move util/stringify-safe to root shared folder

* feat: move util/uen-validation to root shared folder

* feat: move util/url-validation to root shared folder

* feat: move util/verification to root shared folder

* feat: move util/verified-content to root shared folder

* feat: rename shared/util to shared/utils

* feat: move src/shared/resources to shared/constants/field

the old place was confusing. The exported elements are basically constants

* feat: extract file related constants in src/shared/constants

move them to shared/constants/file

* feat: extract link constants into own shared/constants/link.ts

* feat: use DateSelectedValidation in shared instead of types

* feat: add TODO to complete shared/logic

* fix: use relative paths in utils/field-validation

typescript would not correctly compile when absolute path is used for some reason, will debug in the future.
this causes crashes when typescript feature such enums are used, since the types are not compiled.
* feat: loosen esrvcId validation to only restrict whitespace

* test(FormModel): add unit test for validating esrvcId
* ref: move client-only response types to own folder

* feat: remove unused ClientSubmission interface

* feat: add submission content types for email mode

* feat: add server-side ParsedEmailModeSubmissionBody types

denotes the shape after passing the dto through email submission middlewares

* ref: add and use public storage mode submission types

* feat: add specific types for Email and Encrypt mode submissions

* feat: clean up some response types

* fix: remove extraneous period in comment
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.959.0 to 2.960.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.959.0...v2.960.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.17.7 to 14.17.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts:
#	.eslintrc
#	.travis.yml
#	tsconfig.json
@karrui karrui merged commit 8cb1fd9 into form-v2/develop Aug 10, 2021
@karrui karrui deleted the merge-dev-to-form-v2 branch August 10, 2021 03:00
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.