Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up remaining client type imports using backend types #2510

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 3, 2021

Problem

This PR cleans up the remaining types on the client side that is still using backend types.

Note that deprecated types that will not follow us into React are left alone.
This is namely

  • the old PublicFormUpdate DTO
  • Examples related types, since that is going to be deprecated

This PR will complete #2066 once it is merged alongside with #2509

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible
    • Moving types only

Features:

  • refactor: move src/types/api/auth to shared/types/form/form_auth

@karrui karrui requested review from mantariksh and tshuli August 3, 2021 02:42
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed in #2355 (#2355 (comment), #2355 (comment)), do we need to clean up the aliases and exports as well?

@karrui
Copy link
Contributor Author

karrui commented Aug 4, 2021

as discussed in #2355 (#2355 (comment), #2355 (comment)), do we need to clean up the aliases and exports as well?

Yes, will be separate PR. I guess we can extend the scope of #2066 hahaha

Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok approving on the basis that the additional cleanup will come separately

@karrui karrui merged commit f428b93 into develop Aug 4, 2021
@karrui karrui deleted the feat/dto-form-updates branch August 4, 2021 05:03
@karrui karrui mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants