-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type DTOs using domain oriented design that client/server types extend from #2066
Labels
Comments
r00dgirl
added
P2
planned for next 1-2 months
and removed
discuss
to be discussed
labels
Jun 7, 2021
karrui
added a commit
that referenced
this issue
Jun 7, 2021
in preparation for extending from to close #2066
karrui
added a commit
that referenced
this issue
Jun 9, 2021
in preparation for extending from to close #2066
Accidentally closed by commit message |
Merged
This was referenced Jul 7, 2021
This was referenced Jul 14, 2021
This was referenced Aug 3, 2021
Only src/shared/util/logic.ts is remaining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, our DTO types are too coupled with server-side implementation, making the client dependent on server-side modules (such as mongo) to get the appropriate types.
This issue proposes DTO types to be completely free of such dependencies and instead be client/server agnostic. Server side types should instead extend from the DTO types to generate their own typings.
This change will properly allow types to be shared between frontend and backend without any (possibly incompatible - between commonjs and node implementations, for example) dependencies
Current implementation
Proposed implementation
The text was updated successfully, but these errors were encountered: