Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-types): move core, FormFeedback related types to root shared folder #2394

Merged
merged 5 commits into from
Jul 27, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jul 14, 2021

Problem

Continuation from #2385, this PR moves the core and formfeedback types to the new shared folder.

Related to #2066

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible
    • Pure refactor

@karrui karrui force-pushed the feat/dto-form-feedback branch from 39ce019 to b12b813 Compare July 14, 2021 05:06
@karrui karrui force-pushed the feat/dto-form-feedback branch from 406a748 to 77406fc Compare July 26, 2021 08:54
@karrui
Copy link
Contributor Author

karrui commented Jul 26, 2021

I screwed up the rebase :(

@karrui karrui force-pushed the feat/dto-form-feedback branch from 77406fc to c684904 Compare July 26, 2021 11:01
Base automatically changed from feat/dto-form to develop July 27, 2021 02:28
@karrui karrui force-pushed the feat/dto-form-feedback branch from c684904 to d177abc Compare July 27, 2021 02:30
@karrui karrui merged commit 6e3a593 into develop Jul 27, 2021
@karrui karrui deleted the feat/dto-form-feedback branch July 27, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants