feat: correctly type FormFeedbackDto

opengovsg · Jul 14, 2021 · b12b813 · b12b813
1 parent 493c25b
commit b12b813
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/shared/types/form/form_feedback.ts b/shared/types/form/form_feedback.ts
@@ -1,3 +1,4 @@
+import { Merge } from 'type-fest'
 import { DateString } from '../generic'
 import { FormDto } from './form'
 
@@ -14,10 +15,15 @@ export type FormFeedbackBase = {
   rating: number
   comment?: string
   formId: FormDto['_id']
-  created?: DateString
-  lastModified?: DateString
+  created?: Date
+  lastModified?: Date
 }
-export type FormFeedbackDto = FormFeedbackBase
+
+// Convert to serialized version.
+export type FormFeedbackDto = Merge<
+  FormFeedbackBase,
+  { created?: DateString; lastModified?: DateString }
+>
 
 export type ProcessedFeedbackMeta = {
   index: number