Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: remove backend package dependencies from Form (sub-)types and move to shared dir #2385

Merged
merged 15 commits into from
Jul 27, 2021
Merged

ref: remove backend package dependencies from Form (sub-)types and move to shared dir #2385

merged 15 commits into from
Jul 27, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jul 13, 2021 •
edited
Loading

Problem

Continuation from #2355, this PR moves the form and form sub types (form logic, form, public form slices) to the new shared folder.

Related to #2066

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible
    • Pure refactor

@karrui karrui mentioned this pull request Jul 14, 2021
Merged
2 tasks
@karrui
Copy link
Contributor Author

karrui commented Jul 14, 2021

Form logic types may be affected by #2302

@karrui karrui force-pushed the feat/dto-form-field branch from c8514cb to 56f094c Compare July 14, 2021 04:59
@karrui karrui mentioned this pull request Jul 15, 2021
Merged
2 tasks
mantariksh
mantariksh approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving on the basis that code compiles and tests pass

shared/types/field/index.ts Show resolved Hide resolved
shared/types/form/form.ts Outdated Show resolved Hide resolved
src/app/modules/form/admin-form/admin-form.controller.ts Show resolved Hide resolved
Base automatically changed from feat/dto-form-field to develop July 26, 2021 08:49
karrui added 14 commits July 26, 2021 16:50
@karrui
feat: add shared base for form_logo types
b3019b0
@karrui
feat: add shared base for form_logic types
f83c1ec
@karrui
feat: add shared base for form types
45167ff
@karrui
feat(form_logo): use shared types
4d7cefb
@karrui
fix: correct logicType of PreventSubmitLogic
689c92f
@karrui
feat: use shared logic types and allow logic discrimination
a3c44e9
@karrui
feat: add shared form constants for form settings and public fields
2fcbba3
@karrui
feat(form): create PublicFormDto and FormSettings types
7e90f1f
@karrui
feat: use new shared types in backend
20c2b36
@karrui
feat: add more DTO types to shared/types
c028798
@karrui
ref: export shared types from backend types
63f9078 
for use in rest of backend
@karrui
ref(client): import form types from shared instead of backend dir
4a5fe31
@karrui
ref(backend): sync types with client, update tests
42651d3
@karrui
ref: set all default keys in FormBase to be required
973b590 
reverse the schema to make form base keys optional when extending
@karrui karrui merged commit 70490f5 into develop Jul 27, 2021
@karrui karrui deleted the feat/dto-form branch July 27, 2021 02:28
@mantariksh mantariksh mentioned this pull request Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrui @mantariksh