chore: remove express-device #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should probably check that the user agent string still appears as expected in the Cloudwatch logs |
|
True. I would think that user-agent logging is a built-in functionality of express itself. |
timotheeg
force-pushed
the
remove_express_device
branch
from
9c3c5b1 to
ac422f6
Compare
|
Tested on staging with User-Agent still showing in log 👍 If someone has extra context on why we were using |
mantariksh
approved these changes
Aug 2, 2021
|
Right 😄 ! Well, I'm just going to merge then. @liangyuanruo if you remember something, let us know :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have a vulnerability report on express-device here
express-device has not been upgraded for some time, but diving deeper in code, it looks like we do not actually use the capabilities provided by express-device ? 🤔
The following command yields nothing:
git grep -E 'is_(desktop|phone|tablet|mobile|tv|bot|car)|device_(type|name)'Approach
Remove express-device and all the references.