Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: loosen esrvcId validation to only restrict whitespace #2521

Merged
merged 2 commits into from
Aug 4, 2021
Merged

feat: loosen esrvcId validation to only restrict whitespace #2521

merged 2 commits into from
Aug 4, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 3, 2021 •
edited
Loading

Problem

Closes #2466

Tests

  • Unit tests have been added to form schema

Manual tests

  • Go to form, add esrvcId with whitespace. Should reject.
  • Go to form, add esrvcId with any characters except whitespace. Should accept.

Prod tests

  • Go to form, add INVALID esrvcId with any characters except whitespace. Should accept. Activate form. Modal should reject and prevent form from being activated.

@karrui karrui requested review from mantariksh and tshuli August 3, 2021 10:44
@karrui karrui merged commit d6b849c into develop Aug 4, 2021
@karrui karrui deleted the feat/esrvcid-allow-everything-but-space branch August 4, 2021 05:14
This was referenced Aug 5, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

@tshuli tshuli Awaiting requested review from tshuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update form eservice id validation
2 participants
@karrui @mantariksh