Fix error when creating new product on Admin panel #6250

tsara27 · 2020-10-26T04:19:32Z

What? Why?

Closes #6117

I am adding conditional to check variants first before updating the stock items when creating a product.

What should we test?

Test the new product creation on admin panel.

How to do:

Login as an admin.
Go to products.
Create a new product.
Fill other required details, leave the unit value empty.

Changelog Category: Fixed

andrewpbrett · 2020-10-31T00:13:45Z

Hi @tsara27, thanks for submitting this. It looks like some tests now fail as a result, so we'll need those to pass before we can consider merging this.

The on_hand and on_demand fields probably don't need to be changed to fix this, since those have to do with variant stock. I think the fix will be somewhere in the product model or controller.

….env['PATH_INFO'] will work correctly

There are multiple forms of pluralisation here, with different translations for each. перевод сложен !

andrewpbrett · 2020-10-31T20:27:05Z

Hi @tsara27 - this is looking better now! It looks like some specs are still failing because the factory creates a product without specifying a unit_value and so the object fails validation. You could take a look at the product factory and feel free to update it to provide a unit_value and I think that would take care of a few of them.

I did checkout this branch locally and confirm that the tests fail locally for me and not just on Semaphore.

…slavic-plurals Add missing translation keys for Eastern Slavic plurals

tsara27 · 2020-11-01T06:29:06Z

Hi @tsara27 - this is looking better now! It looks like some specs are still failing because the factory creates a product without specifying a unit_value and so the object fails validation. You could take a look at the product factory and feel free to update it to provide a unit_value and I think that would take care of a few of them.

I did checkout this branch locally and confirm that the tests fail locally for me and not just on Semaphore.

Thank you Andrew! I am fixing all specs now.

…ies-banner update template path for cookies banner, fix openfoodfoundation#6284

… Cycle

SIMPLE: added scripts for running test suite in quiet mode

…inal Paypal payment confirmation.

👍

…d-truncate-html-gem Remove unused truncate_html gem

Move Spree::Admin::BaseController to Admin::BaseController

Add task to print Subscriptions debug info

…ansifex Transifex

…vert-6277-controllers Revert "Move Spree::Admin::BaseController to Admin::BaseController"

…tock-clashes Paypal stock clashes

…ey-base Update secret key base

…penfoodnetwork into pr/6250

hound · 2020-11-30T18:41:15Z

spec/services/checkout/form_data_adapter_spec.rb

@@ -38,7 +38,7 @@

      describe "and a credit card is provided" do
        before do
-          params[:order][:payments_attributes].first[:source_attributes] = {number: "4444333322221111"}
+          params[:order][:payments_attributes].first[:source_attributes] = { number: "4444333322221111" }


Metrics/LineLength: Line is too long. [105/100]

hound · 2020-11-30T18:41:15Z

spec/requests/api/orders_spec.rb

-          let!(:order_dist_1_complete) { create(:order,  distributor: order_dist_1.distributor, state: 'complete', completed_at: Time.zone.today - 7.days) }
-          let!(:order_dist_1_credit_owed) { create(:order,  distributor: order_dist_1.distributor, payment_state: 'credit_owed', completed_at: Time.zone.today) }
+          let!(:order_dist_1_complete) { create(:order, distributor: order_dist_1.distributor, state: 'complete', completed_at: Time.zone.today - 7.days) }
+          let!(:order_dist_1_credit_owed) { create(:order, distributor: order_dist_1.distributor, payment_state: 'credit_owed', completed_at: Time.zone.today) }


Metrics/LineLength: Line is too long. [160/100]

hound · 2020-11-30T18:41:15Z

spec/requests/api/orders_spec.rb

          }
        }
        context "when there are four orders with different properties set" do
          let!(:order_dist_1) { create(:order_with_distributor, email: "[email protected]") }
          let!(:order_dist_2) { create(:order_with_totals_and_distribution) }
-          let!(:order_dist_1_complete) { create(:order,  distributor: order_dist_1.distributor, state: 'complete', completed_at: Time.zone.today - 7.days) }
-          let!(:order_dist_1_credit_owed) { create(:order,  distributor: order_dist_1.distributor, payment_state: 'credit_owed', completed_at: Time.zone.today) }
+          let!(:order_dist_1_complete) { create(:order, distributor: order_dist_1.distributor, state: 'complete', completed_at: Time.zone.today - 7.days) }


Metrics/LineLength: Line is too long. [155/100]

hound · 2020-11-30T18:41:16Z

spec/models/spree/variant_spec.rb

+    context "price parsing" do
+      before(:each) do
+        I18n.locale = I18n.default_locale
+        I18n.backend.store_translations(:de, { number: { currency: { format: { delimiter: '.', separator: ',' } } } })


Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Metrics/LineLength: Line is too long. [118/100]

hound · 2020-11-30T18:41:16Z

spec/models/spree/product_spec.rb

+        Spree::Property.where(name: 'foo').first_or_create!(presentation: "Foo's Presentation Name")
+        product.set_property('foo', 'value1')
+        product.set_property('bar', 'value2')
+        expect(Spree::Property.where(name: 'foo').first.presentation).to eq "Foo's Presentation Name"


Metrics/LineLength: Line is too long. [101/100]

hound · 2020-11-30T18:41:17Z

spec/models/spree/order_inventory_spec.rb

@@ -103,8 +103,8 @@

      it 'should destroy backordered units first' do
        allow(shipment).to receive_messages(inventory_units_for: [build(:inventory_unit, variant_id: variant.id, state: 'backordered'),
-                                            build(:inventory_unit, variant_id: variant.id, state: 'on_hand'),
-                                            build(:inventory_unit, variant_id: variant.id, state: 'backordered')])
+                                                                  build(:inventory_unit, variant_id: variant.id, state: 'on_hand'),


Metrics/LineLength: Line is too long. [131/100]

hound · 2020-11-30T18:41:18Z

spec/models/spree/order/checkout_spec.rb

@@ -60,7 +60,7 @@
    it "cannot transition to address without any line items" do
      expect(order.line_items).to be_blank
      expect(lambda { order.next! }).to raise_error(StateMachine::InvalidTransition,
-                                                /#{Spree.t(:there_are_no_items_for_this_order)}/)
+                                                    /#{Spree.t(:there_are_no_items_for_this_order)}/)


Metrics/LineLength: Line is too long. [101/100]

hound · 2020-11-30T18:41:18Z

spec/lib/action_dispatch/request_spec.rb

+  end
+
+  it "doesn't convert an empty array to nil" do
+    expect(parse_query_parameters('key[]')).to eq({ "key" => [] })


Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.

hound · 2020-11-30T18:41:18Z

spec/lib/action_dispatch/request_spec.rb

+  it "strips nils from nested arrays" do
+    expect(
+      parse_query_parameters('key1[key2][]=value&key1[key2][]')
+    ).to eq({ "key1" => { "key2" => ["value"] } })


Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.

hound · 2020-11-30T18:41:18Z

spec/lib/action_dispatch/request_spec.rb

+
+describe ActionDispatch::Request do
+  it "strips nils from arrays" do
+    expect(parse_query_parameters('key[]=value&key[]')).to eq({ "key" => ["value"] })


Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.

andrewpbrett · 2020-11-30T19:15:25Z

Hi @tsara27 - I tried to rebase this branch to resolve the conflicts from removing spree and I'm afraid I made a big mess of it. I think it happened because I merged master in instead of replaying these changes on top of the latest... and now I'm not able to undo the merge. I made a fresh PR instead. Sorry about that! I'm going to close this issue so we can use the new one instead.

tsara27 · 2020-12-01T06:58:50Z

Hello @andrewpbrett,

No problem. Thank you for helping me recreating a fresh PR. 🙂

I did not have time for few weeks to work on this project because I got project from my full time work to finish everything before the holiday. 😢

tsara27 marked this pull request as draft October 26, 2020 04:54

sigmundpetersen assigned tsara27 Oct 26, 2020

tsara27 force-pushed the fix-invalid-unit-value branch 2 times, most recently from 97444e2 to c2d130e Compare October 31, 2020 07:32

tsara27 marked this pull request as ready for review October 31, 2020 07:33

tsara27 force-pushed the fix-invalid-unit-value branch from 5c8ebf7 to 054abc5 Compare October 31, 2020 07:40

luisramos0 added 5 commits October 31, 2020 09:51

Move Spree::Admin::BaseController to Admin::BaseController

66ba9ff

Adapt code from Spree::Admin::BaseController to Admin::BaseController

eb07a91

Change usage of Spree::Admin::BaseController to Admin::BaseController

c997218

Add frozen string literal

af71338

Adapt spec to the move of the controller, in prod the call to request…

fa77204

….env['PATH_INFO'] will work correctly

tsara27 marked this pull request as draft October 31, 2020 13:16

Fix error when setting stock for new product

31a8fd7

tsara27 force-pushed the fix-invalid-unit-value branch from f8931e7 to 31a8fd7 Compare October 31, 2020 13:42

tsara27 marked this pull request as ready for review October 31, 2020 13:42

Matt-Yorkley added 2 commits October 31, 2020 16:58

Add missing translation keys for Eastern Slavic plurals

bc40088

There are multiple forms of pluralisation here, with different translations for each. перевод сложен !

Add missing translation key for enterprise taxon ordering

0af20e4

Merge pull request openfoodfoundation#6280 from Matt-Yorkley/eastern-…

1bb7fd9

…slavic-plurals Add missing translation keys for Eastern Slavic plurals

Transifex-Openfoodnetwork and others added 9 commits November 2, 2020 18:56

Updating translations for config/locales/ru.yml

8904273

Updating translations for config/locales/ru.yml

b23d667

Updating translations for config/locales/en_FR.yml

04358df

Updating translations for config/locales/en_FR.yml

6ff8cad

Updating translations for config/locales/fr.yml

5c81f64

update template path for cookies banner, fix openfoodfoundation#6284

04f5249

Merge pull request openfoodfoundation#6288 from andrewpbrett/fix-cook…

9de7450

…ies-banner update template path for cookies banner, fix openfoodfoundation#6284

Add subs debug task that prints out basic info about a specific Order…

2b01c80

… Cycle

Add log entries to log

c072155

andrewpbrett and others added 24 commits November 20, 2020 10:41

fix/silence rubocop styles

b1b422b

Merge pull request openfoodfoundation#6390 from jhsu802701/qtest

8f25568

SIMPLE: added scripts for running test suite in quiet mode

Extract stock-check logic to controller concern and inject prior to f…

87df447

…inal Paypal payment confirmation.

Fix Rubocop warnings and tidy up

cabec7e

Add spec coverage, refactor, avoid double-render errors

2fa2a30

👍

Merge pull request openfoodfoundation#6362 from coopdevs/remove-unuse…

b089404

…d-truncate-html-gem Remove unused truncate_html gem

Updating translations for config/locales/ca.yml

8861f5c

Updating translations for config/locales/es.yml

ee44159

Updating translations for config/locales/ca.yml

e9eb905

Updating translations for config/locales/en_AU.yml

54feb2f

Updating translations for config/locales/en_NZ.yml

1266a37

Added introductory information for testing.

55b2131

Merge pull request openfoodfoundation#6277 from luisramos0/controllers

9e2a3d6

Move Spree::Admin::BaseController to Admin::BaseController

Merge pull request openfoodfoundation#6293 from luisramos0/subs_debug

8b6a084

Add task to print Subscriptions debug info

Merge pull request openfoodfoundation#6408 from openfoodfoundation/tr…

17957ed

…ansifex Transifex

Improve order test in paypal controller spec

c4cfc1d

Ensure order is cleanly reset to cart state when redirecting to cart

0ba670b

Revert "Move Spree::Admin::BaseController to Admin::BaseController"

3bfa903

Merge pull request openfoodfoundation#6423 from openfoodfoundation/re…

27586d0

…vert-6277-controllers Revert "Move Spree::Admin::BaseController to Admin::BaseController"

Merge pull request openfoodfoundation#6391 from Matt-Yorkley/paypal-s…

07a72ec

…tock-clashes Paypal stock clashes

Merge pull request openfoodfoundation#6357 from Matt-Yorkley/secret-k…

f0a052b

…ey-base Update secret key base

Fix error when setting stock for new product

b02efb6

resolve merge conflict

88266bf

Merge branch 'fix-invalid-unit-value' of https://github.com/tsara27/o…

7bba755

…penfoodnetwork into pr/6250

hound bot reviewed Nov 30, 2020

View reviewed changes

andrewpbrett mentioned this pull request Nov 30, 2020

Fix invalid unit value (rebase of #6250) #6431

Merged

andrewpbrett closed this Nov 30, 2020

filipefurtad0 mentioned this pull request Dec 2, 2020

Mandatory fields in product creation #6447

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix error when creating new product on Admin panel #6250

Fix error when creating new product on Admin panel #6250

tsara27 commented Oct 26, 2020 •

edited by sigmundpetersen

Loading

andrewpbrett commented Oct 31, 2020

andrewpbrett commented Oct 31, 2020

tsara27 commented Nov 1, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

hound bot Nov 30, 2020

andrewpbrett commented Nov 30, 2020

tsara27 commented Dec 1, 2020

Fix error when creating new product on Admin panel #6250

Fix error when creating new product on Admin panel #6250

Conversation

tsara27 commented Oct 26, 2020 • edited by sigmundpetersen Loading

What? Why?

What should we test?

andrewpbrett commented Oct 31, 2020

andrewpbrett commented Oct 31, 2020

tsara27 commented Nov 1, 2020

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

hound bot Nov 30, 2020

Choose a reason for hiding this comment

andrewpbrett commented Nov 30, 2020

tsara27 commented Dec 1, 2020

tsara27 commented Oct 26, 2020 •

edited by sigmundpetersen

Loading