Add task to print Subscriptions debug info #6293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Yorkley
approved these changes
Nov 3, 2020
andrewpbrett
approved these changes
Nov 20, 2020
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
sauloperez
reviewed
Nov 27, 2020
| puts "Canceled at #{subscription.canceled_at} and paused at #{subscription.paused_at}" | ||
|
|
||
| ProxyOrder.where(order_cycle_id: order_cycle_id, | ||
| subscription_id: subscription.id).each do |proxy_order| |
There was a problem hiding this comment.
We should stay on the safe side with all these DB fetches using find_each and avoid potential problems in the future with all these nested iterations loading all these objects. I'm happy to go on with this and fix it in a separate PR myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I think we need a few apges on the app itself for this but this is a start: whoever is debugging a specific Order Cycle can now run this task and get very useful info about what is going on in the subscriptions of the given Order Cycle.
I have done this a few dozen times in prod now, I thought of not doing it again. Each of the parts of this data will explain many different support scenarios and questions: from paused subscriptions, expired credit cards to failed stripe payments.
What should we test?
Run this task with a Order cycle ID and get info from all subscriptions affected by the Order Cycle.
Release notes
Changelog Category: Technical changes
Make Subscriptions debugging easier for developers.