update template path for cookies banner, fix #6284 #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pro tip for posterity: You can get the banner to show up in dev by commenting out lines 4 and 6 of the CookiesBanner directive. (There's probably a more Correct Way to do it but that was what I found that worked). |
Matt-Yorkley
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #6284
What should we test?
Directly visiting a shop page in private mode should display the cookies banner
Release notes
Fixed a bug where the cookies banner did not display on pages other than the homepage.
Changelog Category: User facing changes
Dependencies
Documentation updates