Fix invalid unit value (rebase of #6250) #6431
Conversation
|
@sauloperez I noticed that you'd written some of the specs related to this, so I thought you'd be a good person to review it :) |
spec/features/admin/products_spec.rb
Outdated
| fill_in 'product_on_hand', with: 0 | ||
| check 'product_on_demand' | ||
| select 'Test Tax Category', from: 'product_tax_category_id' | ||
| page.find("div[id^='taTextElement']").native.send_keys('In demand, and on_demand! The hottest cakes in town.') |
There was a problem hiding this comment.
we don't actually need to specify page. find is globally available just like the other Capybara form in put methods
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
Hey @andrewpbrett , Great - this seems to work fine now. I tested the Units field with both numeric and non-numeric values, in both pages:
In all cases, the error "Unit value can't be blank" is displayed now:
This is good to go. Would it be a good idea to extend this test case in the specs: to all other mandatory fields? We recently had an S2 related to this #6393 - Opened #6447 on this. Something else noticed while testing: "Display as" and "on hand" don't seem to be mandatory fields - it's possible to create products without filling in anything. Updated #6159 to reflect this. |
What? Why?
Closes #6117
Closes #3912
Closes #4959
See the original PR (#6250) for details; I tried to rebase it after the spree updates and couldn't untangle things... sorry @tsara27 !
There is still a lot left to be desired in this UI; as @Erioldoesdesign noted, it isn't very clear what this field is for. Moreover the error now says "unit value can't be blank" but the label on the field itself is "value"; and even moreover, if you do fill in the field but with something that's not a number, because it's confusing what should go in there, you get the same "unit value can't be blank" error.
So yes, lots of potential for further improvement here...but this gets rid of the 500 slug. And closes three issues for the price of one!
What should we test?
Login as an admin.
Go to products.
Create a new product.
Fill other required details, leave the unit value empty.
Should see an error and not a slug.
Release notes
Fixed a bug where entering an empty or invalid value on the product creation page would show a slug instead of an error message.
Changelog Category: User facing changes
Dependencies
Documentation updates