-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tagging] Display a unit's tags in the tag drawer #118
Comments
Linking to the Figma conversation for easy reference when the below decision has been made:
|
Note: the above decision has been made :) |
@yusuf-musleh @bradenmacdonald Everything seems to be working quite well in the sandbox. I just have a few comments:
P.s. I will be creating a separate issue with a few additional styling requests, but I will probably wait until the first round of testing has been completed so that I can account for user feedback there too. |
@ali-hugo Thanks for the feedback, glad to hear things are working well. I will include the suggested changes along with other feedback I get on openedx/frontend-app-authoring#704 once its reviewed. Though the first point (changing the order of items in unit menu would be a different PR in the edx-platform repo) |
For the order of the menu, I will include it in FAL-3537. |
@yusuf-musleh Thank you! This looks great :) |
"As a content author, I can see what tags have been applied to a unit in my course (from the course outline page)"
Acceptance Criteria
From the course outline page:
a. There is a new "Manage Tags" menu item available on each unit (only units, not subsections etc.). Clicking it will open the new tag drawer.
b. For units which have tags, the number of tags that they have appears next to this tag icon. Clicking the number/icon will also open the tag drawer.
c. Both the "Manage Tags" and the tags count should only appear to users who have a feature flag enabled (same feature flag as [Tagging] Create Taxonomies List Page (in Course Authoring MFE) #104)
The tag drawer appears on the right, and displays the tags that are applied to the unit, separated by Taxonomy.
Tags are displayed using these criteria:
A scrollbar appears for long lists (see Figma)
For each taxonomy there is a count of tags displayed (see mockups)
For this story, we do not implement any editing (no adding nor deleting tags)
Everything must be fully keyboard accessible. Checking what tags are applied using a screen reader should be easy and make sense. Pressing ESC should close the drawer.
The tag drawer must be implemented in React.
Developer Notes
The text was updated successfully, but these errors were encountered: