Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] Display a unit's tags in the tag drawer #118

Closed
bradenmacdonald opened this issue Sep 21, 2023 · 7 comments
Closed

[Tagging] Display a unit's tags in the tag drawer #118

bradenmacdonald opened this issue Sep 21, 2023 · 7 comments

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 21, 2023

"As a content author, I can see what tags have been applied to a unit in my course (from the course outline page)"

Acceptance Criteria

  1. From the course outline page:
    a. There is a new "Manage Tags" menu item available on each unit (only units, not subsections etc.). Clicking it will open the new tag drawer.
    Screenshot 2023-09-21 at 12 24 45 PM
    b. For units which have tags, the number of tags that they have appears next to this tag icon. Clicking the number/icon will also open the tag drawer.
    Screenshot 2023-09-21 at 2 44 49 PM
    c. Both the "Manage Tags" and the tags count should only appear to users who have a feature flag enabled (same feature flag as [Tagging] Create Taxonomies List Page (in Course Authoring MFE) #104)

  2. The tag drawer appears on the right, and displays the tags that are applied to the unit, separated by Taxonomy.
    Screenshot 2023-09-30 at 4 36 40 PM

    Screenshot 2023-09-21 at 12 30 39 PM

  3. Tags are displayed using these criteria:
    Screenshot 2023-09-21 at 12 31 10 PM

  4. A scrollbar appears for long lists (see Figma)

  5. For each taxonomy there is a count of tags displayed (see mockups)

  6. For this story, we do not implement any editing (no adding nor deleting tags)

  7. Everything must be fully keyboard accessible. Checking what tags are applied using a screen reader should be easy and make sense. Pressing ESC should close the drawer.

  8. The tag drawer must be implemented in React.

Developer Notes

  • The drawer should probably be built in frontend-app-course-authoring and use an iframe to display it in the "old" course authoring experience. If you want to take any other approach please clear it with @bradenmacdonald first.
  • Screenshots above are for convenience - Figma is the most up-to-date source for mockups. The scale of UI elements seen in the screenshots above may be incorrect.
  • Because of [Tagging] Enforce limit on number of tags per object #99 note that the list of tags on each unit is never paginated. This should simplify things a little bit.
@ali-hugo
Copy link

Linking to the Figma conversation for easy reference when the below decision has been made:

(TBD: what exactly appears on the left? Asked on Figma)

@bradenmacdonald bradenmacdonald removed the pending UX changes This issue (not a PR) needs UX input or its UX design is not yet finalized. label Sep 30, 2023
@bradenmacdonald
Copy link
Contributor Author

Note: the above decision has been made :)

@bradenmacdonald bradenmacdonald moved this from To refine to Refined - To do in Modular Learning - Tagging and Libraries Oct 12, 2023
@bradenmacdonald bradenmacdonald moved this from Refined - To do to In Progress in Modular Learning - Tagging and Libraries Oct 26, 2023
@ali-hugo
Copy link

ali-hugo commented Nov 28, 2023

@yusuf-musleh @bradenmacdonald Everything seems to be working quite well in the sandbox. I just have a few comments:

  • Please change the order of the items in the unit menu to:
    • Configure
    • Manage tags
    • Copy to clipboard
    • Duplicate
    • Delete
  • The number next to the taxonomy name in the tag drawer should include all implicit and explicit tags. It only seems to include a count of explicit tags at the moment
  • Remove the hover effect from the tags. Only display a hover effect for the X's next to explicit tags (since this is the only part of the tag that is currently clickable)
    • In the design files, the user can expand and collapse parent tags, but I'm interested to see what test users think of the current implementation (i.e. users can only expand and collapse the taxonomy as a whole)

P.s. I will be creating a separate issue with a few additional styling requests, but I will probably wait until the first round of testing has been completed so that I can account for user feedback there too.

@yusuf-musleh
Copy link
Member

@ali-hugo Thanks for the feedback, glad to hear things are working well. I will include the suggested changes along with other feedback I get on openedx/frontend-app-authoring#704 once its reviewed. Though the first point (changing the order of items in unit menu would be a different PR in the edx-platform repo)

@bradenmacdonald
Copy link
Contributor Author

For the order of the menu, I will include it in FAL-3537.

@yusuf-musleh
Copy link
Member

@ali-hugo I updated my PR to include the count of the implicit tags and remove the hover effect except for the "X" on the explicit tags. It looks like this now:

Screen Shot 2023-11-29 at 3 09 01 PM

@ali-hugo
Copy link

@yusuf-musleh Thank you! This looks great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants