-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0036] fix: allows taxonomy list to "filter by org" even if org does not exist #33686
[FC-0036] fix: allows taxonomy list to "filter by org" even if org does not exist #33686
Conversation
If the user requests the taxonomies linked to a non-existent org, then we want to see the non-org taxonomies.
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Sandbox deploy request received. Deployment will start soon. |
Sandbox deployment started. |
Sandbox deployment failed. Check failure logs here https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5494062867.log Please check the settings and requirements and retry deployment by updating the pull request or posting a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pomegranited Thanks for the fix! It looks great to me! 👍
- I tested this: (followed the testing instructions)
- I read through the code
-
I checked for accessibility issues -
Includes documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-secure
repository.
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
If the user requests the taxonomies linked to a non-existent org, then we want to see the non-org taxonomies.
Description
Allows the "taxonomy list" endpoint to filter by
org
even if the requestedorg
is not found in theOrganizations
list.Previously, attempting to filter taxonomies by a non-existent org would throw an error (400 Bad Request).
With this change, filtering by an non-existent org will return only the (global) instance-level taxonomies.
This case comes up in devstack (the
edX
Organization for the DemoX is not automatically created), and may also affect other small deployments which don't use Organizations.Supporting information
Came across this while testing PRs for openedx/modular-learning#118
Testing instructions
If you don't already have sample taxonomy/tags data, follow the instructions in this repo to generate sample data: https://github.com/open-craft/taxonomy-sample-data
Visit the "taxonomy list" endpoint, with no filters: http://localhost:18010/api/content_tagging/v1/taxonomies/
All taxonomies should be returned.
Visit the "taxonomy list" endpoint and filter by a non-existent org, e.g. http://localhost:18010/api/content_tagging/v1/taxonomies/?org=edX
Only those taxonomies with
all_orgs=True
should be listed.Deadline
None
Other information
Private-ref: FAL-3523