Display tag counts on course outline [FC-0036] #33696
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
bradenmacdonald
changed the title
|
Sandbox deployment started. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33696-139931.staging.do.opencraft.hosting |
|
Sandbox deployment started. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33696-139931.staging.do.opencraft.hosting |
| @@ -18,7 +18,7 @@ def create_taxonomy( | |||
| name: str, | |||
| description: str | None = None, | |||
| enabled=True, | |||
| allow_multiple=False, | |||
| allow_multiple=True, | |||
There was a problem hiding this comment.
While I was at it, I changed this: all taxonomies should default to allowing multiple tags. We actually don't officially support "single tag only" for now.
There was a problem hiding this comment.
👍 Looks good!
- I tested this: (followed the instruction, checked the tag numbers appear and are match the numbers in the tag drawer)
- I read through the code
- I checked for accessibility issues
- Includes documentation
-
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
|
@Agrendalath Could you please review this as CC? |
bradenmacdonald
force-pushed
the
braden/display-tag-counts-on-outline
branch
from
46dc52d to
63db17b
Compare
bradenmacdonald
force-pushed
the
braden/display-tag-counts-on-outline
branch
from
63db17b to
b855397
Compare
|
Sandbox update request received. Deployment will start soon. |
|
@bradenmacdonald, sorry for the delayed reply. Looks good to me; we'll need to rebase it before merging, though. |
…counts-on-outline
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thanks @Agrendalath ! |
|
Sandbox update request received. Deployment will start soon. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
…enedx#33696) * feat: display tag counts on outline * fix: taxonomies should default to allow_multiple=True * fix: only load counts once per request * chore: version bump for openedx-learning
Description
When the "tagging/taxonomy" feature flag is on, this updates the course outline page to show the count of tags that are applied to each unit. The data for all units is loaded at once, rather than each unit at a time.
Supporting information
This implements openedx/modular-learning#118 part 1b: "For units which have tags, the number of tags that they have appears next to this tag icon. Clicking the number/icon will also open the tag drawer."
Testing instructions
new_studio_mfe.use_tagging_taxonomy_list_pagewaffle flagDeadline
None
Other information
Depends on:
Private ref: FAL-3564.