feat: Add tags to Units #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
One problem with the current script is it just picks the first tag from each taxonomy, which is never a "grandchild" tag, and is always a root tag. It would be much better if most of the tags are leaf tags like Landscape Architecture in the LightCast skills taxonomy or Physical Sciences in the Canada taxonomy, or hierarchical taxonomy tag 1.9.13.
- Tag courses/units/components using leaf tags rather than the first level tags for better real life representation of data. - Update tags deletion implementation after implementation changed in edx-platform.
|
@bradenmacdonald Agreed, I think using grandchild (or "leaf") tags are more representative of real life data. I've updated the implementation to tag using the first leaf tag for each taxonomy. I've also updated the tags deletion implementation to account for the changes made in edx-platform related to tags. |
bradenmacdonald
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements tagging Units in the sample courses. This should help with testing features/functionality related to tags on units.
Related Tickets:
Testing Instructions
Similar to what is mentioned in the README:
To begin, clone this repo inside a directory so it can be accessed from within the devstack (eg:
/edx/src/)Set the
TAXONOMY_SAMPLE_PATHvariable inside thegenerate.pyfile to point to the cloned repo inside your devstack/tutor environment, eg:/edx/src/taxonomy-sample-dataTo run the script, enter the LMS shell (
make lms-shell) and run the following command:python manage.py cms shell < /path/to/taxonomy-sample-data/generate.pyThe script should run to completion, you'll notice it tagging the the units (vertical blocks) in the logs of the script
Private-ref: FAL-3523