Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] Access unit/component tags from the Unit page #120

Closed
bradenmacdonald opened this issue Sep 21, 2023 · 2 comments · Fixed by openedx/edx-platform#33645 or openedx/edx-platform#33761

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 21, 2023

"As a content author, I can see what tags have been applied to a unit in my course (from within the unit page)"

"As a content author, I can see what tags have been applied to individual components in my course (from the unit page)"

Follows #118

Acceptance criteria

  1. In the right sidebar on the unit page, it indicates how many tags the unit has, shows the specific tags (collapsed at first), and has a button to open the tag drawer (same tag drawer as from [Tagging] Display a unit's tags in the tag drawer #118).
    Screenshot 2023-10-11 at 2 13 41 PM
    Screenshot 2023-10-11 at 2 14 13 PM

  2. For each individual component (XBlock), the "three dots" menu gets a new "Manage tags" option which will open the tag drawer for that component.
    Screenshot 2023-09-21 at 2 57 34 PM

Developer notes

  • Screenshots above are for convenience - Figma is the most up-to-date source for mockups. The scale of UI elements seen in the screenshots above may be incorrect.
@ali-hugo
Copy link

@ChrisChV @bradenmacdonald Thanks for your work on this! It's looking good. Here are a few small things I noticed when clicking through the sandbox:

  • There is a strange 'jump' when I first expand the "Tags" sidebar component. The area containing the "Tags" heading, tag count, and up/down arrow seems to shift down a few pixels when it is first clicked
  • This section also shows a dotted outline after it is selected (see screenshot below):
Screenshot 2023-11-28 at 13 49 39
  • If a tag cannot be expanded (i.e. leaf tags), it should not have a hover state (in the screenshot below, "flat taxonomy tag 2949" should be black, not blue):
Screenshot 2023-11-28 at 14 00 00

Please change the order of the items in the component menu to:

  • Manage Access
  • Move
  • Manage tags
  • Copy to Clipboard
  • Duplicate
  • Delete

@bradenmacdonald
Copy link
Contributor Author

bradenmacdonald commented Nov 28, 2023

^ We will fix the above shortly in #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment