Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fixes force merge failing on long executions, changes some action mes… #267

Merged
merged 9 commits into from
Aug 3, 2020

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Aug 3, 2020

…saging, adds better try/catch on actions to deal with remote transport exceptions

Issue #, if available:
#266, #250

Description of changes:
This is a bit of a loaded pull request.

  • It changes some of the action message wording to hopefully be a bit more clear. We might change it further to add more information as the "info" object is really supposed to just be a place to dump human friendly/usable information to know what's going on.
  • It fixes the force merge bug that would fail if your force merge took too long. This was from the connection not being closed after force merge gets queued/kicked off. We now will hold the connection for up to 5 minutes and then just assume it has succeeded and move on to the wait for step.
  • A lot of the action failure messages were useless because of the RemoteTransportException. Correctly catches them in each action and gets the useful error message/cause.
  • Added a pre/post execute to steps.
  • Fixed some action(s) not correctly catching a snapshot exception that was wrapped in a RemoteTransportException.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #267 into master will increase coverage by 3.76%.
The diff coverage is 72.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
+ Coverage     71.58%   75.34%   +3.76%     
- Complexity      651      704      +53     
============================================
  Files            89       89              
  Lines          3772     3914     +142     
  Branches        619      627       +8     
============================================
+ Hits           2700     2949     +249     
+ Misses          747      640     -107     
  Partials        325      325              
Impacted Files Coverage Δ Complexity Δ
...ement/model/coordinator/SweptManagedIndexConfig.kt 86.48% <ø> (ø) 8.00 <0.00> (ø)
...sticsearch/indexstatemanagement/util/IndexUtils.kt 76.92% <ø> (ø) 1.00 <0.00> (ø)
...dexstatemanagement/elasticapi/ElasticExtensions.kt 65.38% <20.00%> (-6.05%) 0.00 <0.00> (ø)
...nagement/step/forcemerge/AttemptSetReadOnlyStep.kt 43.90% <21.05%> (-8.88%) 4.00 <0.00> (ø)
...anagement/step/forcemerge/WaitForForceMergeStep.kt 32.05% <25.00%> (-1.29%) 5.00 <1.00> (ø)
...ement/step/notification/AttemptNotificationStep.kt 57.57% <25.00%> (-4.50%) 5.00 <0.00> (ø)
...atemanagement/step/rollover/AttemptRolloverStep.kt 54.70% <35.71%> (-2.59%) 14.00 <8.00> (ø)
...ement/step/forcemerge/AttemptCallForceMergeStep.kt 66.66% <64.70%> (+0.95%) 7.00 <1.00> (+4.00)
...exstatemanagement/step/delete/AttemptDeleteStep.kt 78.26% <77.77%> (-5.62%) 6.00 <2.00> (+2.00) ⬇️
...anagement/step/allocation/AttemptAllocationStep.kt 79.48% <84.61%> (+3.01%) 6.00 <1.00> (+1.00)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a967aa...ccea177. Read the comment docs.

@dbbaughe dbbaughe merged commit a8ac5a3 into opendistro-for-elasticsearch:master Aug 3, 2020
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates Allocation step with message and execute changes

* Updates Allocation test message

* Updates jacoco source so the source files show up in the report

* Adds tests for wait for snapshot step

* Adds tests for attempt snapshot step and some missing license headers

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Adds tests for wait for snapshot step

* Adds tests for attempt snapshot step and some missing license headers

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit to dbbaughe/index-management that referenced this pull request Aug 4, 2020
opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
#267) (#270)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
#267) (#268)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates Allocation step with message and execute changes

* Updates Allocation test message

* Updates jacoco source so the source files show up in the report

* Adds tests for wait for snapshot step

* Adds tests for attempt snapshot step and some missing license headers

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
#267) (#269)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Adds tests for wait for snapshot step

* Adds tests for attempt snapshot step and some missing license headers

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
…tests (#271)

* Adds rollover conditions into info object (#208)

* Fixes force merge failing on long executions, changes some action mes… (#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
…tests (#272)

* Adds rollover conditions into info object (#208)

* Fixes force merge failing on long executions, changes some action mes… (#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
…tests (#273)

* Adds rollover conditions into info object (#208)

* Fixes force merge failing on long executions, changes some action mes… (#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
…tests (#274)

* Adds rollover conditions into info object (#208)

* Fixes force merge failing on long executions, changes some action mes… (#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
…tests (#275)

* Adds rollover conditions into info object (#208)

* Fixes force merge failing on long executions, changes some action mes… (#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
…tests (#276)

* Adds rollover conditions into info object (#208)

* Fixes force merge failing on long executions, changes some action mes… (#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
dbbaughe added a commit that referenced this pull request Aug 4, 2020
…tests (#277)

* Adds rollover conditions into info object (#208)

* Fixes force merge failing on long executions, changes some action mes… (#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Addressing comments on naming and spacing
@bowenlan-amzn bowenlan-amzn added the enhancement An improvement on the existing feature’s functionalities label Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement on the existing feature’s functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants