This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Fixes force merge failing on long executions, changes some action mes… #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
============================================
+ Coverage 71.58% 75.34% +3.76%
- Complexity 651 704 +53
============================================
Files 89 89
Lines 3772 3914 +142
Branches 619 627 +8
============================================
+ Hits 2700 2949 +249
+ Misses 747 640 -107
Partials 325 325 Continue to review full report at Codecov.
|
…saging, adds better try/catch on actions to deal with remote transport exceptions
qreshi
reviewed
Aug 3, 2020
src/main/kotlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/step/Step.kt
Show resolved
Hide resolved
.../com/amazon/opendistroforelasticsearch/indexstatemanagement/step/delete/AttemptDeleteStep.kt
Outdated
Show resolved
Hide resolved
...opendistroforelasticsearch/indexstatemanagement/step/forcemerge/AttemptCallForceMergeStep.kt
Show resolved
Hide resolved
.../amazon/opendistroforelasticsearch/indexstatemanagement/step/rollover/AttemptRolloverStep.kt
Outdated
Show resolved
Hide resolved
...opendistroforelasticsearch/indexstatemanagement/step/forcemerge/AttemptCallForceMergeStep.kt
Show resolved
Hide resolved
src/main/kotlin/com/amazon/opendistroforelasticsearch/indexstatemanagement/step/Step.kt
Show resolved
Hide resolved
This was referenced Aug 3, 2020
bowenlan-amzn
approved these changes
Aug 3, 2020
qreshi
approved these changes
Aug 3, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates Allocation step with message and execute changes * Updates Allocation test message * Updates jacoco source so the source files show up in the report * Adds tests for wait for snapshot step * Adds tests for attempt snapshot step and some missing license headers * Addressing comments on naming and spacing
This was referenced Aug 4, 2020
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Adds tests for wait for snapshot step * Adds tests for attempt snapshot step and some missing license headers * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
to dbbaughe/index-management
that referenced
this pull request
Aug 4, 2020
opendistro-for-elasticsearch#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
#267) (#270) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
#267) (#268) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates Allocation step with message and execute changes * Updates Allocation test message * Updates jacoco source so the source files show up in the report * Adds tests for wait for snapshot step * Adds tests for attempt snapshot step and some missing license headers * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
#267) (#269) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Adds tests for wait for snapshot step * Adds tests for attempt snapshot step and some missing license headers * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#271) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#272) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#273) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#274) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#275) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#276) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
dbbaughe
added a commit
that referenced
this pull request
Aug 4, 2020
…tests (#277) * Adds rollover conditions into info object (#208) * Fixes force merge failing on long executions, changes some action mes… (#267) * Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions * Adds unit tests for failures in steps * Adds more tests * Updates jacoco source so the source files show up in the report * Addressing comments on naming and spacing
bowenlan-amzn
added
the
enhancement
An improvement on the existing feature’s functionalities
label
Aug 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…saging, adds better try/catch on actions to deal with remote transport exceptions
Issue #, if available:
#266, #250
Description of changes:
This is a bit of a loaded pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.