Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add additional unit tests for snapshot logic #245

Closed
dbbaughe opened this issue Jun 25, 2020 · 1 comment
Closed

Add additional unit tests for snapshot logic #245

dbbaughe opened this issue Jun 25, 2020 · 1 comment
Assignees
@dbbaughe
Labels
testing

Comments

@dbbaughe
Copy link
Contributor

There were a few bugs in snapshot action which have been addressed in this PR:
#244

Added a few more integration tests, but there are some branches in the steps that are hard to test through integration tests (like snapshot status returning INIT, WAITING, etc.) so will cover these in unit tests.
@dbbaughe dbbaughe self-assigned this Jun 25, 2020
@dbbaughe dbbaughe mentioned this issue Jul 16, 2020
Merged
@dbbaughe
Copy link
Contributor Author

dbbaughe commented Aug 3, 2020

Added unit tests for them in here #267

@dbbaughe dbbaughe closed this as completed Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbbaughe dbbaughe

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbbaughe