Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fixes force merge failing on long executions, changes some action mes… #269

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Aug 4, 2020

…… (#267)

  • Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

  • Adds unit tests for failures in steps

  • Adds more tests

  • Updates jacoco source so the source files show up in the report

  • Adds tests for wait for snapshot step

  • Adds tests for attempt snapshot step and some missing license headers

  • Addressing comments on naming and spacing

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates jacoco source so the source files show up in the report

* Adds tests for wait for snapshot step

* Adds tests for attempt snapshot step and some missing license headers

* Addressing comments on naming and spacing
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #269 into opendistro-1.8 will increase coverage by 3.81%.
The diff coverage is 71.30%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             opendistro-1.8     #269      +/-   ##
====================================================
+ Coverage             71.16%   74.98%   +3.81%     
- Complexity              617      667      +50     
====================================================
  Files                    83       83              
  Lines                  3628     3758     +130     
  Branches                600      608       +8     
====================================================
+ Hits                   2582     2818     +236     
+ Misses                  735      627     -108     
- Partials                311      313       +2     
Impacted Files Coverage Δ Complexity Δ
...ement/model/coordinator/SweptManagedIndexConfig.kt 86.48% <ø> (ø) 8.00 <0.00> (ø)
...dexstatemanagement/elasticapi/ElasticExtensions.kt 65.38% <20.00%> (-1.97%) 0.00 <0.00> (ø)
...nagement/step/forcemerge/AttemptSetReadOnlyStep.kt 42.50% <21.05%> (-10.28%) 4.00 <0.00> (ø)
...anagement/step/forcemerge/WaitForForceMergeStep.kt 32.05% <25.00%> (-1.29%) 5.00 <1.00> (ø)
...ement/step/notification/AttemptNotificationStep.kt 57.57% <25.00%> (-4.50%) 5.00 <0.00> (ø)
...atemanagement/step/rollover/AttemptRolloverStep.kt 54.70% <35.71%> (-2.59%) 14.00 <8.00> (ø)
...ement/step/forcemerge/AttemptCallForceMergeStep.kt 66.66% <64.70%> (+0.95%) 7.00 <1.00> (+4.00)
...exstatemanagement/step/delete/AttemptDeleteStep.kt 78.26% <77.77%> (-5.62%) 6.00 <2.00> (+2.00) ⬇️
...anagement/step/transition/AttemptTransitionStep.kt 86.76% <87.50%> (+42.69%) 12.00 <10.00> (+8.00)
.../indexstatemanagement/step/open/AttemptOpenStep.kt 86.84% <94.73%> (+33.50%) 5.00 <3.00> (+2.00)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0944fe0...0880b6b. Read the comment docs.

@dbbaughe dbbaughe merged commit 316535a into opendistro-for-elasticsearch:opendistro-1.8 Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants