Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fixes force merge failing on long executions, changes some action mes… #268

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Aug 4, 2020

…… (#267)

  • Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

  • Adds unit tests for failures in steps

  • Adds more tests

  • Updates jacoco source so the source files show up in the report

  • Adds tests for wait for snapshot step

  • Adds tests for attempt snapshot step and some missing license headers

  • Addressing comments on naming and spacing

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

opendistro-for-elasticsearch#267)

* Fixes force merge failing on long executions, changes some action messaging, adds better try/catch on actions to deal with remote transport exceptions

* Adds unit tests for failures in steps

* Adds more tests

* Updates Allocation step with message and execute changes

* Updates Allocation test message

* Updates jacoco source so the source files show up in the report

* Adds tests for wait for snapshot step

* Adds tests for attempt snapshot step and some missing license headers

* Addressing comments on naming and spacing
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #268 into opendistro-1.9 will increase coverage by 3.78%.
The diff coverage is 72.43%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             opendistro-1.9     #268      +/-   ##
====================================================
+ Coverage             71.55%   75.33%   +3.78%     
- Complexity              635      685      +50     
====================================================
  Files                    86       86              
  Lines                  3691     3828     +137     
  Branches                608      616       +8     
====================================================
+ Hits                   2641     2884     +243     
+ Misses                  734      627     -107     
- Partials                316      317       +1     
Impacted Files Coverage Δ Complexity Δ
...ement/model/coordinator/SweptManagedIndexConfig.kt 86.48% <ø> (ø) 8.00 <0.00> (ø)
...sticsearch/indexstatemanagement/util/IndexUtils.kt 76.92% <ø> (ø) 1.00 <0.00> (ø)
...dexstatemanagement/elasticapi/ElasticExtensions.kt 65.38% <20.00%> (-6.05%) 0.00 <0.00> (ø)
...nagement/step/forcemerge/AttemptSetReadOnlyStep.kt 43.90% <21.05%> (-8.88%) 4.00 <0.00> (ø)
...anagement/step/forcemerge/WaitForForceMergeStep.kt 32.05% <25.00%> (-1.29%) 5.00 <1.00> (ø)
...ement/step/notification/AttemptNotificationStep.kt 57.57% <25.00%> (-4.50%) 5.00 <0.00> (ø)
...atemanagement/step/rollover/AttemptRolloverStep.kt 54.70% <35.71%> (-2.59%) 14.00 <8.00> (ø)
...ement/step/forcemerge/AttemptCallForceMergeStep.kt 66.66% <64.70%> (+0.95%) 7.00 <1.00> (+4.00)
...exstatemanagement/step/delete/AttemptDeleteStep.kt 78.26% <77.77%> (-5.62%) 6.00 <2.00> (+2.00) ⬇️
...anagement/step/transition/AttemptTransitionStep.kt 86.76% <87.50%> (+42.69%) 12.00 <10.00> (+8.00)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848a663...6c004b3. Read the comment docs.

@dbbaughe dbbaughe merged commit c7b8d36 into opendistro-for-elasticsearch:opendistro-1.9 Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants