Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @OlivierAlbertini as JavaScript approver #166

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Aug 30, 2019

List of contributions to the OpenTelemetry project

@mayurkale22
Copy link
Member Author

@OlivierAlbertini please confirm your commitment

Copy link
Contributor

@bhs bhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Thank you, Olivier!)

@bogdandrutu bogdandrutu merged commit 890cc26 into open-telemetry:master Sep 3, 2019
@mayurkale22
Copy link
Member Author

Thanks @bogdandrutu. I added him in the owners list, but I still don't see an approver icon on OlivierAlbertini open-telemetry/opentelemetry-js#233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants