-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme for opentelemetry-core #113
Merged
mayurkale22
merged 1 commit into
open-telemetry:master
from
OlivierAlbertini:feature/update-readme-opentelemetry-core
Jul 23, 2019
Merged
Update readme for opentelemetry-core #113
mayurkale22
merged 1 commit into
open-telemetry:master
from
OlivierAlbertini:feature/update-readme-opentelemetry-core
Jul 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierAlbertini
requested review from
danielkhan,
iredelmeier,
justindsmith,
mayurkale22 and
rochdev
as code owners
July 22, 2019 19:14
mayurkale22
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a few comments
OlivierAlbertini
force-pushed
the
feature/update-readme-opentelemetry-core
branch
from
July 22, 2019 21:36
1b1a37a
to
7f89b58
Compare
mayurkale22
reviewed
Jul 22, 2019
related to open-telemetry#96 Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
force-pushed
the
feature/update-readme-opentelemetry-core
branch
from
July 22, 2019 22:24
7f89b58
to
1802d83
Compare
mayurkale22
approved these changes
Jul 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 27 27
Lines 1784 1784
Branches 201 201
=======================================
Hits 1764 1764
Misses 20 20 |
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…dis-4.x chore(deps): update dependency @types/ioredis to v4.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #96
Signed-off-by: Olivier Albertini [email protected]