feat: Add B3format propagator #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
danielkhan,
iredelmeier and
rochdev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 82.65% 84.05% +1.39%
==========================================
Files 52 54 +2
Lines 1776 1938 +162
Branches 125 151 +26
==========================================
+ Hits 1468 1629 +161
- Misses 308 309 +1
|
danielkhan
reviewed
Aug 26, 2019
packages/opentelemetry-core/src/context/propagation/B3Format.ts
Outdated
Show resolved
Hide resolved
bg451
approved these changes
Aug 28, 2019
| } | ||
|
|
||
| /** | ||
| * Propagator for the B3 HTTP header format. |
There was a problem hiding this comment.
Maybe note that this is for multiple headers, not single headers (since the b3 spec mentions both ways of propagating)
danielkhan
reviewed
Aug 29, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
… span name (open-telemetry#208) * fix: ensure span name is a string to avoid [object Object] as span name Signed-off-by: Naseem <[email protected]> * fix: make test read better Signed-off-by: Naseem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes