Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SimpleSpanProcessor #218

Merged

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Aug 23, 2019

Which problem is this PR solving?

  • Built-in implementation of SpanProcessor.

Short description of the changes

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkhan
Copy link
Contributor

@mayurkale22 - is it required from the spec to call it SimpleSampledSpanProcessor? I am wondering because isn't implicit that only sampled spans will be processed?

@mayurkale22 mayurkale22 force-pushed the span_processor_based_on_specs branch from d8c68ae to 5c4f0a9 Compare August 26, 2019 17:42
@mayurkale22 mayurkale22 changed the title feat: add SimpleSampledSpanProcessor feat: add SimpleSpanProcessor Aug 26, 2019
@mayurkale22
Copy link
Member Author

@mayurkale22 - is it required from the spec to call it SimpleSampledSpanProcessor? I am wondering because isn't implicit that only sampled spans will be processed?

Hmm, ok. I changed it to SimpleSpanProcessor.

@mayurkale22 mayurkale22 added this to the SDK complete milestone Aug 29, 2019
@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #218 into master will decrease coverage by 11.77%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #218       +/-   ##
===========================================
- Coverage   94.43%   82.65%   -11.78%     
===========================================
  Files          51       52        +1     
  Lines        1851     1776       -75     
  Branches      122      129        +7     
===========================================
- Hits         1748     1468      -280     
- Misses        103      308      +205
Impacted Files Coverage Δ
...sic-tracer/test/export/SimpleSpanProcessor.test.ts 100% <100%> (ø)
...try-basic-tracer/src/export/SimpleSpanProcessor.ts 100% <100%> (ø)
...kages/opentelemetry-basic-tracer/test/Span.test.ts 0% <0%> (-100%) ⬇️
...ages/opentelemetry-basic-tracer/src/BasicTracer.ts 22.22% <0%> (-75.93%) ⬇️
packages/opentelemetry-basic-tracer/src/Span.ts 35.59% <0%> (-64.41%) ⬇️
...telemetry-node-tracer/src/instrumentation/utils.ts 95.83% <0%> (-4.17%) ⬇️
...metry-node-tracer/src/instrumentation/constants.ts 100% <0%> (ø) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...pentelemetry-basic-tracer/test/BasicTracer.test.ts
... and 2 more

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #218 into master will decrease coverage by 11.77%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #218       +/-   ##
===========================================
- Coverage   94.43%   82.65%   -11.78%     
===========================================
  Files          51       52        +1     
  Lines        1851     1776       -75     
  Branches      122      129        +7     
===========================================
- Hits         1748     1468      -280     
- Misses        103      308      +205
Impacted Files Coverage Δ
...sic-tracer/test/export/SimpleSpanProcessor.test.ts 100% <100%> (ø)
...try-basic-tracer/src/export/SimpleSpanProcessor.ts 100% <100%> (ø)
...kages/opentelemetry-basic-tracer/test/Span.test.ts 0% <0%> (-100%) ⬇️
...ages/opentelemetry-basic-tracer/src/BasicTracer.ts 22.22% <0%> (-75.93%) ⬇️
packages/opentelemetry-basic-tracer/src/Span.ts 35.59% <0%> (-64.41%) ⬇️
...telemetry-node-tracer/src/instrumentation/utils.ts 95.83% <0%> (-4.17%) ⬇️
...metry-node-tracer/src/instrumentation/constants.ts 100% <0%> (ø) ⬆️
...try-node-tracer/test/instrumentation/utils.test.ts 100% <0%> (ø) ⬆️
...e-tracer/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...pentelemetry-basic-tracer/test/BasicTracer.test.ts
... and 2 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants