-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add InMemorySpanExporter, MultiSpanProcessor #234
feat: add InMemorySpanExporter, MultiSpanProcessor #234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 98.78% 98.78% -0.01%
==========================================
Files 55 60 +5
Lines 2146 2221 +75
Branches 147 152 +5
==========================================
+ Hits 2120 2194 +74
- Misses 26 27 +1
|
packages/opentelemetry-basic-tracer/src/export/InMemorySpanExporter.ts
Outdated
Show resolved
Hide resolved
this._finishedSpan = []; | ||
} | ||
|
||
reset() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stopped = false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reset
is just to clean the collected spans. If we make it stopped = false
, it won't export/collect any spans after reset
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job!
defe812
to
e075f8b
Compare
Which problem is this PR solving?
Short description of the changes
InMemorySpanExporter
, it can be used for testing purposes, especially in the plugins. It stores the exported spans in a list in memory.