Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convention test to ensure pagination methods meet naming conventions #771

Merged
merged 4 commits into from
Apr 6, 2015
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Octokit/Clients/AssigneesClient.cs
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ public AssigneesClient(IApiConnection apiConnection) : base(apiConnection)
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
public Task<IReadOnlyList<User>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<User>> GetAllForRepository(string owner, string name)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
10 changes: 5 additions & 5 deletions Octokit/Clients/EventsClient.cs
Original file line number Diff line number Diff line change
@@ -89,7 +89,7 @@ public Task<IReadOnlyList<Activity>> GetAllForOrganization(string organization)
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the <see cref="Activity"/>s that a particular user has received.</returns>
public Task<IReadOnlyList<Activity>> GetUserReceived(string user)
public Task<IReadOnlyList<Activity>> GetAllUserReceived(string user)
{
Ensure.ArgumentNotNullOrEmptyString(user, "user");

@@ -104,7 +104,7 @@ public Task<IReadOnlyList<Activity>> GetUserReceived(string user)
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the <see cref="Activity"/>s that a particular user has received.</returns>
public Task<IReadOnlyList<Activity>> GetUserReceivedPublic(string user)
public Task<IReadOnlyList<Activity>> GetAllUserReceivedPublic(string user)
{
Ensure.ArgumentNotNullOrEmptyString(user, "user");

@@ -119,7 +119,7 @@ public Task<IReadOnlyList<Activity>> GetUserReceivedPublic(string user)
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the <see cref="Activity"/>s that a particular user has performed.</returns>
public Task<IReadOnlyList<Activity>> GetUserPerformed(string user)
public Task<IReadOnlyList<Activity>> GetAllUserPerformed(string user)
{
Ensure.ArgumentNotNullOrEmptyString(user, "user");

@@ -134,7 +134,7 @@ public Task<IReadOnlyList<Activity>> GetUserPerformed(string user)
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the public <see cref="Activity"/>s that a particular user has performed.</returns>
public Task<IReadOnlyList<Activity>> GetUserPerformedPublic(string user)
public Task<IReadOnlyList<Activity>> GetAllUserPerformedPublic(string user)
{
Ensure.ArgumentNotNullOrEmptyString(user, "user");

@@ -150,7 +150,7 @@ public Task<IReadOnlyList<Activity>> GetUserPerformedPublic(string user)
/// <param name="user">The login of the user</param>
/// <param name="organization">The name of the organization</param>
/// <returns>All the public <see cref="Activity"/>s that are associated with an organization.</returns>
public Task<IReadOnlyList<Activity>> GetForAnOrganization(string user, string organization)
public Task<IReadOnlyList<Activity>> GetAllForAnOrganization(string user, string organization)
{
Ensure.ArgumentNotNullOrEmptyString(user, "user");
Ensure.ArgumentNotNullOrEmptyString(organization, "organization");
4 changes: 2 additions & 2 deletions Octokit/Clients/FollowersClient.cs
Original file line number Diff line number Diff line change
@@ -54,7 +54,7 @@ public Task<IReadOnlyList<User>> GetAll(string login)
/// See the <a href="http://developer.github.com/v3/users/followers/#list-users-followed-by-another-user">API documentation</a> for more information.
/// </remarks>
/// <returns>A <see cref="IReadOnlyList{User}"/> of <see cref="User"/>s that the authenticated user follows.</returns>
public Task<IReadOnlyList<User>> GetFollowingForCurrent()
public Task<IReadOnlyList<User>> GetAllFollowingForCurrent()
{
return ApiConnection.GetAll<User>(ApiUrls.Following());
}
@@ -67,7 +67,7 @@ public Task<IReadOnlyList<User>> GetFollowingForCurrent()
/// See the <a href="http://developer.github.com/v3/users/followers/#list-users-followed-by-another-user">API documentation</a> for more information.
/// </remarks>
/// <returns>A <see cref="IReadOnlyList{User}"/> of <see cref="User"/>s that the passed user follows.</returns>
public Task<IReadOnlyList<User>> GetFollowing(string login)
public Task<IReadOnlyList<User>> GetAllFollowing(string login)
{
Ensure.ArgumentNotNullOrEmptyString(login, "login");

2 changes: 1 addition & 1 deletion Octokit/Clients/GistCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ public Task<GistComment> Get(string gistId, int commentId)
/// <remarks>http://developer.github.com/v3/gists/comments/#list-comments-on-a-gist</remarks>
/// <param name="gistId">The id of the gist</param>
/// <returns>Task{IReadOnlyList{GistComment}}.</returns>
public Task<IReadOnlyList<GistComment>> GetForGist(string gistId)
public Task<IReadOnlyList<GistComment>> GetAllForGist(string gistId)
{
return ApiConnection.GetAll<GistComment>(ApiUrls.GistComments(gistId));
}
2 changes: 1 addition & 1 deletion Octokit/Clients/IAssigneesClient.cs
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ public interface IAssigneesClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
Task<IReadOnlyList<User>> GetForRepository(string owner, string name);
Task<IReadOnlyList<User>> GetAllForRepository(string owner, string name);

/// <summary>
/// Checks to see if a user is an assignee for a repository.
10 changes: 5 additions & 5 deletions Octokit/Clients/IEventsClient.cs
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@ public interface IEventsClient
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the <see cref="Activity"/>s that a particular user has received.</returns>
Task<IReadOnlyList<Activity>> GetUserReceived(string user);
Task<IReadOnlyList<Activity>> GetAllUserReceived(string user);

/// <summary>
/// Gets all the events that have been received by a given user.
@@ -71,7 +71,7 @@ public interface IEventsClient
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the <see cref="Activity"/>s that a particular user has received.</returns>
Task<IReadOnlyList<Activity>> GetUserReceivedPublic(string user);
Task<IReadOnlyList<Activity>> GetAllUserReceivedPublic(string user);

/// <summary>
/// Gets all the events that have been performed by a given user.
@@ -81,7 +81,7 @@ public interface IEventsClient
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the <see cref="Activity"/>s that a particular user has performed.</returns>
Task<IReadOnlyList<Activity>> GetUserPerformed(string user);
Task<IReadOnlyList<Activity>> GetAllUserPerformed(string user);

/// <summary>
/// Gets all the public events that have been performed by a given user.
@@ -91,7 +91,7 @@ public interface IEventsClient
/// </remarks>
/// <param name="user">The login of the user</param>
/// <returns>All the public <see cref="Activity"/>s that a particular user has performed.</returns>
Task<IReadOnlyList<Activity>> GetUserPerformedPublic(string user);
Task<IReadOnlyList<Activity>> GetAllUserPerformedPublic(string user);

/// <summary>
/// Gets all the events that are associated with an organization.
@@ -102,6 +102,6 @@ public interface IEventsClient
/// <param name="user">The login of the user</param>
/// <param name="organization">The name of the organization</param>
/// <returns>All the public <see cref="Activity"/>s that are associated with an organization.</returns>
Task<IReadOnlyList<Activity>> GetForAnOrganization(string user, string organization);
Task<IReadOnlyList<Activity>> GetAllForAnOrganization(string user, string organization);
}
}
4 changes: 2 additions & 2 deletions Octokit/Clients/IFollowersClient.cs
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ public interface IFollowersClient
/// </remarks>
/// <returns>A <see cref="IReadOnlyList{User}"/> of <see cref="User"/>s that the authenticated user follows.</returns>
[SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
Task<IReadOnlyList<User>> GetFollowingForCurrent();
Task<IReadOnlyList<User>> GetAllFollowingForCurrent();

/// <summary>
/// List who a user is following
@@ -50,7 +50,7 @@ public interface IFollowersClient
/// See the <a href="http://developer.github.com/v3/users/followers/#list-users-followed-by-another-user">API documentation</a> for more information.
/// </remarks>
/// <returns>A <see cref="IReadOnlyList{User}"/> of <see cref="User"/>s that the passed user follows.</returns>
Task<IReadOnlyList<User>> GetFollowing(string login);
Task<IReadOnlyList<User>> GetAllFollowing(string login);

/// <summary>
/// Check if the authenticated user follows another user
2 changes: 1 addition & 1 deletion Octokit/Clients/IGistCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ public interface IGistCommentsClient
/// <remarks>http://developer.github.com/v3/gists/comments/#list-comments-on-a-gist</remarks>
/// <param name="gistId">The id of the gist</param>
/// <returns>Task{IReadOnlyList{GistComment}}.</returns>
Task<IReadOnlyList<GistComment>> GetForGist(string gistId);
Task<IReadOnlyList<GistComment>> GetAllForGist(string gistId);

/// <summary>
/// Creates a comment for the gist with the specified id.
4 changes: 2 additions & 2 deletions Octokit/Clients/IIssueCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ public interface IIssueCommentsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
Task<IReadOnlyList<IssueComment>> GetForRepository(string owner, string name);
Task<IReadOnlyList<IssueComment>> GetAllForRepository(string owner, string name);

/// <summary>
/// Gets Issue Comments for a specified Issue.
@@ -41,7 +41,7 @@ public interface IIssueCommentsClient
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <returns></returns>
Task<IReadOnlyList<IssueComment>> GetForIssue(string owner, string name, int number);
Task<IReadOnlyList<IssueComment>> GetAllForIssue(string owner, string name, int number);

/// <summary>
/// Creates a new Issue Comment for a specified Issue.
4 changes: 2 additions & 2 deletions Octokit/Clients/IIssuesClient.cs
Original file line number Diff line number Diff line change
@@ -126,7 +126,7 @@ public interface IIssuesClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
Task<IReadOnlyList<Issue>> GetForRepository(string owner, string name);
Task<IReadOnlyList<Issue>> GetAllForRepository(string owner, string name);

/// <summary>
/// Gets issues for a repository.
@@ -138,7 +138,7 @@ public interface IIssuesClient
/// <param name="name">The name of the repository</param>
/// <param name="request">Used to filter and sort the list of issues returned</param>
/// <returns></returns>
Task<IReadOnlyList<Issue>> GetForRepository(string owner, string name, RepositoryIssueRequest request);
Task<IReadOnlyList<Issue>> GetAllForRepository(string owner, string name, RepositoryIssueRequest request);

/// <summary>
/// Creates an issue for the specified repository. Any user with pull access to a repository can create an
4 changes: 2 additions & 2 deletions Octokit/Clients/IIssuesEventsClient.cs
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ public interface IIssuesEventsClient
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <returns></returns>
Task<IReadOnlyList<EventInfo>> GetForIssue(string owner, string name, int number);
Task<IReadOnlyList<EventInfo>> GetAllForIssue(string owner, string name, int number);

/// <summary>
/// Gets all events for the repository.
@@ -33,7 +33,7 @@ public interface IIssuesEventsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
Task<IReadOnlyList<IssueEvent>> GetForRepository(string owner, string name);
Task<IReadOnlyList<IssueEvent>> GetAllForRepository(string owner, string name);

/// <summary>
/// Gets a single event
6 changes: 3 additions & 3 deletions Octokit/Clients/IIssuesLabelsClient.cs
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ public interface IIssuesLabelsClient
/// <param name="repo">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <returns>The list of labels</returns>
Task<IReadOnlyList<Label>> GetForIssue(string owner, string repo, int number);
Task<IReadOnlyList<Label>> GetAllForIssue(string owner, string repo, int number);

/// <summary>
/// Gets all labels for the repository.
@@ -27,7 +27,7 @@ public interface IIssuesLabelsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="repo">The name of the repository</param>
/// <returns>The list of labels</returns>
Task<IReadOnlyList<Label>> GetForRepository(string owner, string repo);
Task<IReadOnlyList<Label>> GetAllForRepository(string owner, string repo);

/// <summary>
/// Gets a single Label by name.
@@ -141,6 +141,6 @@ public interface IIssuesLabelsClient
/// <param name="repo">The name of the repository</param>
/// <param name="number">The number of the milestone</param>
/// <returns></returns>
Task<IReadOnlyList<Label>> GetForMilestone(string owner, string repo, int number);
Task<IReadOnlyList<Label>> GetAllForMilestone(string owner, string repo, int number);
}
}
4 changes: 2 additions & 2 deletions Octokit/Clients/IMilestonesClient.cs
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ public interface IMilestonesClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
Task<IReadOnlyList<Milestone>> GetForRepository(string owner, string name);
Task<IReadOnlyList<Milestone>> GetAllForRepository(string owner, string name);

/// <summary>
/// Gets all open milestones for the repository.
@@ -44,7 +44,7 @@ public interface IMilestonesClient
/// <param name="name">The name of the repository</param>
/// <param name="request">Used to filter and sort the list of Milestones returned</param>
/// <returns></returns>
Task<IReadOnlyList<Milestone>> GetForRepository(string owner, string name, MilestoneRequest request);
Task<IReadOnlyList<Milestone>> GetAllForRepository(string owner, string name, MilestoneRequest request);

/// <summary>
/// Creates a milestone for the specified repository. Any user with pull access to a repository can create an
6 changes: 3 additions & 3 deletions Octokit/Clients/IMiscellaneousClient.cs
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ public interface IMiscellaneousClient
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
/// <returns>An <see cref="IReadOnlyDictionary{TKey,TValue}"/> of emoji and their URI.</returns>
[SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
Task<IReadOnlyList<Emoji>> GetEmojis();
Task<IReadOnlyList<Emoji>> GetAllEmojis();

/// <summary>
/// Gets the rendered Markdown for the specified plain-text Markdown document.
@@ -35,7 +35,7 @@ public interface IMiscellaneousClient
/// </summary>
/// <returns>A list of template names</returns>
[SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
Task<IReadOnlyList<string>> GetGitIgnoreTemplates();
Task<IReadOnlyList<string>> GetAllGitIgnoreTemplates();

/// <summary>
/// Retrieves the source for a single GitIgnore template
@@ -51,7 +51,7 @@ public interface IMiscellaneousClient
/// <remarks>This is a PREVIEW API! Use it at your own risk.</remarks>
/// <returns>A list of licenses available on the site</returns>
[SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
Task<IReadOnlyList<LicenseMetadata>> GetLicenses();
Task<IReadOnlyList<LicenseMetadata>> GetAllLicenses();

/// <summary>
/// Retrieves a license based on the licence key such as "mit"
2 changes: 1 addition & 1 deletion Octokit/Clients/IOrganizationMembersClient.cs
Original file line number Diff line number Diff line change
@@ -72,7 +72,7 @@ public interface IOrganizationMembersClient
/// <remarks>http://developer.github.com/v3/orgs/members/#public-members-list</remarks>
/// <param name="org">The login for the organization</param>
/// <returns></returns>
Task<IReadOnlyList<User>> GetPublic(string org);
Task<IReadOnlyList<User>> GetAllPublic(string org);

/// <summary>
/// Check if a user is, publicly or privately, a member of the organization.
4 changes: 2 additions & 2 deletions Octokit/Clients/IPullRequestReviewCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ public interface IPullRequestReviewCommentsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns>The list of <see cref="PullRequestReviewComment"/>s for the specified repository</returns>
Task<IReadOnlyList<PullRequestReviewComment>> GetForRepository(string owner, string name);
Task<IReadOnlyList<PullRequestReviewComment>> GetAllForRepository(string owner, string name);

/// <summary>
/// Gets a list of the pull request review comments in a specified repository.
@@ -38,7 +38,7 @@ public interface IPullRequestReviewCommentsClient
/// <param name="name">The name of the repository</param>
/// <param name="request">The sorting <see cref="PullRequestReviewCommentRequest">parameters</see></param>
/// <returns>The list of <see cref="PullRequestReviewComment"/>s for the specified repository</returns>
Task<IReadOnlyList<PullRequestReviewComment>> GetForRepository(string owner, string name, PullRequestReviewCommentRequest request);
Task<IReadOnlyList<PullRequestReviewComment>> GetAllForRepository(string owner, string name, PullRequestReviewCommentRequest request);

/// <summary>
/// Gets a single pull request review comment by number.
4 changes: 2 additions & 2 deletions Octokit/Clients/IPullRequestsClient.cs
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ public interface IPullRequestsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns>A <see cref="IReadOnlyList{PullRequest}"/> of <see cref="PullRequest"/>s which are currently open</returns>
Task<IReadOnlyList<PullRequest>> GetForRepository(string owner, string name);
Task<IReadOnlyList<PullRequest>> GetAllForRepository(string owner, string name);

/// <summary>
/// Query pull requests for the repository based on criteria
@@ -43,7 +43,7 @@ public interface IPullRequestsClient
/// <param name="name">The name of the repository</param>
/// <param name="request">Used to filter and sort the list of pull requests returned</param>
/// <returns>A <see cref="IReadOnlyList{PullRequest}"/> of <see cref="PullRequest"/>s which match the criteria</returns>
Task<IReadOnlyList<PullRequest>> GetForRepository(string owner, string name, PullRequestRequest request);
Task<IReadOnlyList<PullRequest>> GetAllForRepository(string owner, string name, PullRequestRequest request);

/// <summary>
/// Create a pull request for the specified repository.
2 changes: 1 addition & 1 deletion Octokit/Clients/IReleasesClient.cs
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ public interface IReleasesClient
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
/// <returns>The list of <see cref="ReleaseAsset"/> for the specified release of the specified repository.</returns>
Task<IReadOnlyList<ReleaseAsset>> GetAssets(string owner, string name, int id);
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(string owner, string name, int id);

/// <summary>
/// Uploads a <see cref="ReleaseAsset"/> for the specified release.
4 changes: 2 additions & 2 deletions Octokit/Clients/IRepositoryCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ public interface IRepositoryCommentsClient
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
Task<IReadOnlyList<CommitComment>> GetForRepository(string owner, string name);
Task<IReadOnlyList<CommitComment>> GetAllForRepository(string owner, string name);

/// <summary>
/// Gets Commit Comments for a specified Commit.
@@ -41,7 +41,7 @@ public interface IRepositoryCommentsClient
/// <param name="name">The name of the repository</param>
/// <param name="sha">The sha of the commit</param>
/// <returns></returns>
Task<IReadOnlyList<CommitComment>> GetForCommit(string owner, string name, string sha);
Task<IReadOnlyList<CommitComment>> GetAllForCommit(string owner, string name, string sha);

/// <summary>
/// Creates a new Commit Comment for a specified Commit.
2 changes: 1 addition & 1 deletion Octokit/Clients/IRepositoryContentsClient.cs
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ public interface IRepositoryContentsClient
/// <returns>
/// A collection of <see cref="RepositoryContent"/> representing the content at the specified path
/// </returns>
Task<IReadOnlyList<RepositoryContent>> GetContents(string owner, string name, string path);
Task<IReadOnlyList<RepositoryContent>> GetAllContents(string owner, string name, string path);

/// <summary>
/// Gets the preferred README for the specified repository.
4 changes: 2 additions & 2 deletions Octokit/Clients/ITeamsClient.cs
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ public interface ITeamsClient
/// https://developer.github.com/v3/orgs/teams/#list-team-members
/// </remarks>
/// <returns>A list of the team's member <see cref="User"/>s.</returns>
Task<IReadOnlyList<User>> GetMembers(int id);
Task<IReadOnlyList<User>> GetAllMembers(int id);

/// <summary>
/// Returns newly created <see cref="Team" /> for the current org.
@@ -92,7 +92,7 @@ public interface ITeamsClient
/// </summary>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
/// <returns>The team's repositories</returns>
Task<IReadOnlyList<Repository>> GetRepositories(int id);
Task<IReadOnlyList<Repository>> GetAllRepositories(int id);

/// <summary>
/// Add a repository to the team
4 changes: 2 additions & 2 deletions Octokit/Clients/IssueCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ public Task<IssueComment> Get(string owner, string name, int number)
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
public Task<IReadOnlyList<IssueComment>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<IssueComment>> GetAllForRepository(string owner, string name)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
@@ -58,7 +58,7 @@ public Task<IReadOnlyList<IssueComment>> GetForRepository(string owner, string n
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <returns></returns>
public Task<IReadOnlyList<IssueComment>> GetForIssue(string owner, string name, int number)
public Task<IReadOnlyList<IssueComment>> GetAllForIssue(string owner, string name, int number)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
6 changes: 3 additions & 3 deletions Octokit/Clients/IssuesClient.cs
Original file line number Diff line number Diff line change
@@ -164,9 +164,9 @@ public Task<IReadOnlyList<Issue>> GetAllForOrganization(string organization, Iss
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
public Task<IReadOnlyList<Issue>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<Issue>> GetAllForRepository(string owner, string name)
{
return GetForRepository(owner, name, new RepositoryIssueRequest());
return GetAllForRepository(owner, name, new RepositoryIssueRequest());
}

/// <summary>
@@ -179,7 +179,7 @@ public Task<IReadOnlyList<Issue>> GetForRepository(string owner, string name)
/// <param name="name">The name of the repository</param>
/// <param name="request">Used to filter and sort the list of issues returned</param>
/// <returns></returns>
public Task<IReadOnlyList<Issue>> GetForRepository(string owner, string name,
public Task<IReadOnlyList<Issue>> GetAllForRepository(string owner, string name,
RepositoryIssueRequest request)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
4 changes: 2 additions & 2 deletions Octokit/Clients/IssuesEventsClient.cs
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ public IssuesEventsClient(IApiConnection apiConnection) : base(apiConnection)
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <returns></returns>
public Task<IReadOnlyList<EventInfo>> GetForIssue(string owner, string name, int number)
public Task<IReadOnlyList<EventInfo>> GetAllForIssue(string owner, string name, int number)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
@@ -44,7 +44,7 @@ public Task<IReadOnlyList<EventInfo>> GetForIssue(string owner, string name, int
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
public Task<IReadOnlyList<IssueEvent>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<IssueEvent>> GetAllForRepository(string owner, string name)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
6 changes: 3 additions & 3 deletions Octokit/Clients/IssuesLabelsClient.cs
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ public IssuesLabelsClient(IApiConnection apiConnection)
/// <param name="repo">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <returns>The list of labels</returns>
public Task<IReadOnlyList<Label>> GetForIssue(string owner, string repo, int number)
public Task<IReadOnlyList<Label>> GetAllForIssue(string owner, string repo, int number)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(repo, "repo");
@@ -37,7 +37,7 @@ public Task<IReadOnlyList<Label>> GetForIssue(string owner, string repo, int num
/// <param name="owner">The owner of the repository</param>
/// <param name="repo">The name of the repository</param>
/// <returns>The list of labels</returns>
public Task<IReadOnlyList<Label>> GetForRepository(string owner, string repo)
public Task<IReadOnlyList<Label>> GetAllForRepository(string owner, string repo)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(repo, "repo");
@@ -211,7 +211,7 @@ public Task RemoveAllFromIssue(string owner, string repo, int number)
/// <param name="repo">The name of the repository</param>
/// <param name="number">The number of the milestone</param>
/// <returns></returns>
public Task<IReadOnlyList<Label>> GetForMilestone(string owner, string repo, int number)
public Task<IReadOnlyList<Label>> GetAllForMilestone(string owner, string repo, int number)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(repo, "repo");
6 changes: 3 additions & 3 deletions Octokit/Clients/MilestonesClient.cs
Original file line number Diff line number Diff line change
@@ -43,9 +43,9 @@ public Task<Milestone> Get(string owner, string name, int number)
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
public Task<IReadOnlyList<Milestone>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<Milestone>> GetAllForRepository(string owner, string name)
{
return GetForRepository(owner, name, new MilestoneRequest());
return GetAllForRepository(owner, name, new MilestoneRequest());
}

/// <summary>
@@ -58,7 +58,7 @@ public Task<IReadOnlyList<Milestone>> GetForRepository(string owner, string name
/// <param name="name">The name of the repository</param>
/// <param name="request">Used to filter and sort the list of Milestones returned</param>
/// <returns></returns>
public Task<IReadOnlyList<Milestone>> GetForRepository(string owner, string name, MilestoneRequest request)
public Task<IReadOnlyList<Milestone>> GetAllForRepository(string owner, string name, MilestoneRequest request)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
6 changes: 3 additions & 3 deletions Octokit/Clients/MiscellaneousClient.cs
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ public MiscellaneousClient(IConnection connection)
/// </summary>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
/// <returns>An <see cref="IReadOnlyDictionary{TKey,TValue}"/> of emoji and their URI.</returns>
public async Task<IReadOnlyList<Emoji>> GetEmojis()
public async Task<IReadOnlyList<Emoji>> GetAllEmojis()
{
var endpoint = new Uri("emojis", UriKind.Relative);
var response = await _connection.Get<Dictionary<string, string>>(endpoint, null, null)
@@ -61,7 +61,7 @@ public async Task<string> RenderRawMarkdown(string markdown)
/// List all templates available to pass as an option when creating a repository.
/// </summary>
/// <returns>A list of template names</returns>
public async Task<IReadOnlyList<string>> GetGitIgnoreTemplates()
public async Task<IReadOnlyList<string>> GetAllGitIgnoreTemplates()
{
var endpoint = new Uri("gitignore/templates", UriKind.Relative);

@@ -92,7 +92,7 @@ public async Task<GitIgnoreTemplate> GetGitIgnoreTemplate(string templateName)
/// </summary>
/// <remarks>This is a PREVIEW API! Use it at your own risk.</remarks>
/// <returns>A list of licenses available on the site</returns>
public async Task<IReadOnlyList<LicenseMetadata>> GetLicenses()
public async Task<IReadOnlyList<LicenseMetadata>> GetAllLicenses()
{
const string previewAcceptsHeader = "application/vnd.github.drax-preview+json";
var endpoint = new Uri("licenses", UriKind.Relative);
2 changes: 1 addition & 1 deletion Octokit/Clients/OrganizationMembersClient.cs
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ public Task<IReadOnlyList<User>> GetAll(string org, string filter)
/// <remarks>http://developer.github.com/v3/orgs/members/#public-members-list</remarks>
/// <param name="org">The login for the organization</param>
/// <returns></returns>
public Task<IReadOnlyList<User>> GetPublic(string org)
public Task<IReadOnlyList<User>> GetAllPublic(string org)
{
Ensure.ArgumentNotNullOrEmptyString(org, "org");

6 changes: 3 additions & 3 deletions Octokit/Clients/PullRequestReviewCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -40,9 +40,9 @@ public Task<IReadOnlyList<PullRequestReviewComment>> GetAll(string owner, string
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns>The list of <see cref="PullRequestReviewComment"/>s for the specified repository</returns>
public Task<IReadOnlyList<PullRequestReviewComment>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<PullRequestReviewComment>> GetAllForRepository(string owner, string name)
{
return GetForRepository(owner, name, new PullRequestReviewCommentRequest());
return GetAllForRepository(owner, name, new PullRequestReviewCommentRequest());
}

/// <summary>
@@ -53,7 +53,7 @@ public Task<IReadOnlyList<PullRequestReviewComment>> GetForRepository(string own
/// <param name="name">The name of the repository</param>
/// <param name="request">The sorting <see cref="PullRequestReviewCommentRequest">parameters</see></param>
/// <returns>The list of <see cref="PullRequestReviewComment"/>s for the specified repository</returns>
public Task<IReadOnlyList<PullRequestReviewComment>> GetForRepository(string owner, string name, PullRequestReviewCommentRequest request)
public Task<IReadOnlyList<PullRequestReviewComment>> GetAllForRepository(string owner, string name, PullRequestReviewCommentRequest request)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
6 changes: 3 additions & 3 deletions Octokit/Clients/PullRequestsClient.cs
Original file line number Diff line number Diff line change
@@ -40,9 +40,9 @@ public Task<PullRequest> Get(string owner, string name, int number)
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns>A <see cref="IReadOnlyList{PullRequest}"/> of <see cref="PullRequest"/>s which are currently open</returns>
public Task<IReadOnlyList<PullRequest>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<PullRequest>> GetAllForRepository(string owner, string name)
{
return GetForRepository(owner, name, new PullRequestRequest());
return GetAllForRepository(owner, name, new PullRequestRequest());
}

/// <summary>
@@ -55,7 +55,7 @@ public Task<IReadOnlyList<PullRequest>> GetForRepository(string owner, string na
/// <param name="name">The name of the repository</param>
/// <param name="request">Used to filter and sort the list of pull requests returned</param>
/// <returns>A <see cref="IReadOnlyList{PullRequest}"/> of <see cref="PullRequest"/>s which match the criteria</returns>
public Task<IReadOnlyList<PullRequest>> GetForRepository(string owner, string name, PullRequestRequest request)
public Task<IReadOnlyList<PullRequest>> GetAllForRepository(string owner, string name, PullRequestRequest request)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
2 changes: 1 addition & 1 deletion Octokit/Clients/ReleasesClient.cs
Original file line number Diff line number Diff line change
@@ -134,7 +134,7 @@ public Task Delete(string owner, string name, int id)
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
/// <returns>The list of <see cref="ReleaseAsset"/> for the specified release of the specified repository.</returns>
public Task<IReadOnlyList<ReleaseAsset>> GetAssets(string owner, string name, int id)
public Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(string owner, string name, int id)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
4 changes: 2 additions & 2 deletions Octokit/Clients/RepositoryCommentsClient.cs
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ public Task<CommitComment> Get(string owner, string name, int number)
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <returns></returns>
public Task<IReadOnlyList<CommitComment>> GetForRepository(string owner, string name)
public Task<IReadOnlyList<CommitComment>> GetAllForRepository(string owner, string name)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
@@ -60,7 +60,7 @@ public Task<IReadOnlyList<CommitComment>> GetForRepository(string owner, string
/// <param name="name">The name of the repository</param>
/// <param name="sha">The sha of the commit</param>
/// <returns></returns>
public Task<IReadOnlyList<CommitComment>> GetForCommit(string owner, string name, string sha)
public Task<IReadOnlyList<CommitComment>> GetAllForCommit(string owner, string name, string sha)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
2 changes: 1 addition & 1 deletion Octokit/Clients/RepositoryContentsClient.cs
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ public RepositoryContentsClient(IApiConnection apiConnection) : base(apiConnecti
/// <returns>
/// A collection of <see cref="RepositoryContent"/> representing the content at the specified path
/// </returns>
public async Task<IReadOnlyList<RepositoryContent>> GetContents(string owner, string name, string path)
public async Task<IReadOnlyList<RepositoryContent>> GetAllContents(string owner, string name, string path)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
4 changes: 2 additions & 2 deletions Octokit/Clients/TeamsClient.cs
Original file line number Diff line number Diff line change
@@ -60,7 +60,7 @@ public Task<IReadOnlyList<Team>> GetAll(string org)
/// https://developer.github.com/v3/orgs/teams/#list-team-members
/// </remarks>
/// <returns>A list of the team's member <see cref="User"/>s.</returns>
public Task<IReadOnlyList<User>> GetMembers(int id)
public Task<IReadOnlyList<User>> GetAllMembers(int id)
{
var endpoint = ApiUrls.TeamMembers(id);

@@ -158,7 +158,7 @@ public Task RemoveMember(int id, string login)
/// </summary>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
/// <returns>The team's repositories</returns>
public Task<IReadOnlyList<Repository>> GetRepositories(int id)
public Task<IReadOnlyList<Repository>> GetAllRepositories(int id)
{
var endpoint = ApiUrls.TeamRepositories(id);